Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Sep 2020 15:26:39 -0300
From:   Jason Gunthorpe <jgg@ziepe.ca>
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     Sagi Grimberg <sagi@grimberg.me>,
        Yamin Friedman <yaminf@mellanox.com>,
        kernel test robot <rong.a.chen@intel.com>,
        Max Gurtovoy <maxg@mellanox.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg+lists@ziepe.ca>,
        linux-rdma@vger.kernel.org, lkp@lists.01.org
Subject: Re: [IB/srpt] c804af2c1d: last_state.test.blktests.exit_code.143
Message-ID: <20200914182639.GG1221970@ziepe.ca>
References: <20200802060925.GW23458@shao2-debian>
 <f8ef3284-4646-94d9-7eea-14ac0873b03b@acm.org>
 <ed6002b6-cd0c-55c5-c5a5-9c974a476a95@mellanox.com>
 <0c42aeb4-23a5-b9d5-bc17-ef58a04db8e8@grimberg.me>
 <128192ad-05ff-fa8e-14fc-479a115311e0@acm.org>
 <20200824133019.GH1152540@nvidia.com>
 <2a2ff3a5-f58e-8246-fd09-87029b562347@acm.org>
 <20200908182232.GP9166@nvidia.com>
 <e8a240aa-9e9b-3dca-062f-9130b787f29b@acm.org>
 <6c86453d-d7ae-a36b-d827-7812999abc96@acm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6c86453d-d7ae-a36b-d827-7812999abc96@acm.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 11, 2020 at 03:00:30PM -0700, Bart Van Assche wrote:
> On 2020-09-08 19:01, Bart Van Assche wrote:
> > The above patch didn't compile, but the patch below does and makes the hang
> > disappear. So feel free to add the following to the patch below:
> > 
> > Tested-by: Bart Van Assche <bvanassche@acm.org>
> > 
> > diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> > index c36b4d2b61e0..23ee65a9185f 100644
> > +++ b/drivers/infiniband/core/device.c
> > @@ -1285,6 +1285,8 @@ static void disable_device(struct ib_device *device)
> >  		remove_client_context(device, cid);
> >  	}
> > 
> > +	ib_cq_pool_destroy(device);
> > +
> >  	/* Pairs with refcount_set in enable_device */
> >  	ib_device_put(device);
> >  	wait_for_completion(&device->unreg_completion);
> > @@ -1328,6 +1330,8 @@ static int enable_device_and_get(struct ib_device *device)
> >  			goto out;
> >  	}
> > 
> > +	ib_cq_pool_init(device);
> > +
> >  	down_read(&clients_rwsem);
> >  	xa_for_each_marked (&clients, index, client, CLIENT_REGISTERED) {
> >  		ret = add_client_context(device, client);
> > @@ -1400,7 +1404,6 @@ int ib_register_device(struct ib_device *device, const char *name)
> >  		goto dev_cleanup;
> >  	}
> > 
> > -	ib_cq_pool_init(device);
> >  	ret = enable_device_and_get(device);
> >  	dev_set_uevent_suppress(&device->dev, false);
> >  	/* Mark for userspace that device is ready */
> > @@ -1455,7 +1458,6 @@ static void __ib_unregister_device(struct ib_device *ib_dev)
> >  		goto out;
> > 
> >  	disable_device(ib_dev);
> > -	ib_cq_pool_destroy(ib_dev);
> > 
> >  	/* Expedite removing unregistered pointers from the hash table */
> >  	free_netdevs(ib_dev);
> 
> Hi Jason,
> 
> Please let me know how you want to proceed with this patch.

Applied to for-rc

Thanks,
Jason