Subject: Re: apm suspend broken ?
From: Thomas Hood <jdthood@mail.com>
To: linux-kernel@vger.kernel.org
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: 30 Oct 2001 11:18:17 -0500
Message-Id: <1004458698.4243.118.camel@thanatos>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org

I have a question related to this.

If a driver ioctl handler requires
    (filp->f_mode) & FMODE_WRITE
to be set before processing a request, and if only
root has write permission to the device file, does this
make it unnecessary to check for
     capable(CAP_SYS_ADMIN)
?

If we were to use the write permission bit to control
access, then it would not be necessary for the apm
command to be setuid root to give the non-root user
the ability to suspend the machine.  Instead we could
    chgrp apm /dev/apm_bios
    chmod g+w /dev/apm_bios
and add the trusted user to the 'apm' group.

Am I missing something here?

--
Thomas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/