Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2424241pxk; Mon, 14 Sep 2020 13:00:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjnGSiAZfVAnq5lQHBaz5PTAQbvUGZw/TLcvEZKEvxc1AgydxoL0ZhC4YGk1iyRYrpoUnl X-Received: by 2002:a05:6402:228c:: with SMTP id cw12mr19625465edb.174.1600113657674; Mon, 14 Sep 2020 13:00:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600113657; cv=none; d=google.com; s=arc-20160816; b=04d1Addjl38RiTQRtVvGOIi+UacSqv+iWzpi+DYEjjLpJl2GW+pYmwcWbcIvZhlY8V qI2zVnFhqN6My6hqyAtmXti5K2dGHGprMIsivGjVmXCJA5V+W6uENmEHTx95C+HYgeQT g+VGbc8ztZxeZej4yFPDlK6x4jeT6JZvBHJrbxBD3wlKKJhnXrEoeD7fIn4336gjuWNI /ipGLhXgdSAG/TGLjUcET8HyvD6i6h0dmReOBHr2EzG3BBFbzHltwUy1MJX/EckziOai 3HaZS0u4yN0GMrc8E69/AtK1mnOgf03XUToSFDhXltfQRDH6OeXT30Xz1cZlGeeIZzN6 POfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=GMmZZJfFAYNzoH+fmYyCcNIw3gsJUCH293BkfkYSLcU=; b=zmouiIhStKvZr3FKlUUYjZRYhbPObjlJOUQrEGyU3Clpxd15DNIQbH8c/ahe2zpyAQ rx0zigBjVfRT/mT2HcUyDizBrjwx+qRpTeP9idMSHTGUa2HygERsSm5jBVF2Y82W/BIE 9Sv8/vjXugmu10HuMJ1RsZ0oA/N8ED0eozCAdZkV/uyd/0sLkSpDsT89H+q6TM9Ks+R9 NeG5Hc7igQD0PUxCBORHkIFj1qTUwE/FkWgKwVlWeel5qa4EnEiH7YXMbhnGgGOJZgpR GF4HAaDoCsD2TJut3Pbn0nX+RhQHacMgKSoMe20de5sROK/yNEwKVGokZhJ/7nd7riFk ts0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s19si7437828ejv.149.2020.09.14.13.00.34; Mon, 14 Sep 2020 13:00:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725999AbgINT7w (ORCPT + 99 others); Mon, 14 Sep 2020 15:59:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725964AbgINT7w (ORCPT ); Mon, 14 Sep 2020 15:59:52 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9910C06174A; Mon, 14 Sep 2020 12:59:51 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0A5F912354CAC; Mon, 14 Sep 2020 12:42:57 -0700 (PDT) Date: Mon, 14 Sep 2020 12:59:42 -0700 (PDT) Message-Id: <20200914.125942.5644261129883859.davem@davemloft.net> To: npiggin@gmail.com Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, axboe@kernel.dk, peterz@infradead.org Subject: Re: [PATCH v2 3/4] sparc64: remove mm_cpumask clearing to fix kthread_use_mm race From: David Miller In-Reply-To: <20200914045219.3736466-4-npiggin@gmail.com> References: <20200914045219.3736466-1-npiggin@gmail.com> <20200914045219.3736466-4-npiggin@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Mon, 14 Sep 2020 12:42:58 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicholas Piggin Date: Mon, 14 Sep 2020 14:52:18 +1000 ... > The basic fix for sparc64 is to remove its mm_cpumask clearing code. The > optimisation could be effectively restored by sending IPIs to mm_cpumask > members and having them remove themselves from mm_cpumask. This is more > tricky so I leave it as an exercise for someone with a sparc64 SMP. > powerpc has a (currently similarly broken) example. > > Signed-off-by: Nicholas Piggin Sad to see this optimization go away, but what can I do: Acked-by: David S. Miller