Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2426326pxk; Mon, 14 Sep 2020 13:04:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjgbCODmYvL+uuosexOdgXGeQSsGGXjwJtjIO5M17mkBt/F/TtTYW/6ht1n1WDHEzUtJjv X-Received: by 2002:a17:906:fb8c:: with SMTP id lr12mr17267298ejb.9.1600113856506; Mon, 14 Sep 2020 13:04:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600113856; cv=none; d=google.com; s=arc-20160816; b=EF70cvPXvT4PdJ/ofLVz7Z2l5xakBaLkHbBbwBktguIk4z7ZeRhX4I9HqRTHodjN0y a6zGpllCnEh32mhDYopO5Sf54nVwwzEGKgNj8891VVDfRYYmR/soJroTYmJrcsxm9xkl MLFZ4ITgNt4xlJaqxvsjWVtnWSEyIbedDXWaRgkiw7yB1IZ8ZhFomOvVzUoUSN1/KFOy HvQdDkgDw2hgaRNhEQvfD9txVEKc2+zFF8H6zfsegZy4YgFWSacmIyXRS5eVrAgxaaNm ppGjEvlZpZTQt9t9C/KLUQs1cjHEo8n6g7r5lCMJS0QwPbx5MEw3WJAp1q+lVzwwMbjY rg7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=9p103l7MgB9cyoP+SoZc+gfbfUn4jk+RTREMyj+3QRk=; b=DD7lcvBItORrqycAoeyDj+ZbkB5DHMiwmF10zGh3jjra5jmCqyEBGgirPv756HmEf0 QfJT2AlduPbtpG1GbLx7qovYDvgOI2m1Opy/PJIItCA6XIm8CoXXVzmfDal1bPU7oVI5 SLQIW6ZOIf2dtqy3Xr2LvxmgDMBb+pryMU1m4+6hvhZWTaG8yT7Vbrt1kzB/EwBEf/oq jsQ2VRqa3PN/jquLTwumlqPp0XUyxF9iEgcXvNzEKtK427yku7omUIxAAOTYcs/rEfUU P3gjoYQY5eVGv+NdQXNr0UyvANBQNjy80LMTUTCw1jfLFfeVobf+0yveBNsEisaPjIqo qabw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0JSe+BRQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j14si8530538edj.258.2020.09.14.13.03.53; Mon, 14 Sep 2020 13:04:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0JSe+BRQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726028AbgINUDF (ORCPT + 99 others); Mon, 14 Sep 2020 16:03:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:33376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbgINUDC (ORCPT ); Mon, 14 Sep 2020 16:03:02 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 354A5207EA; Mon, 14 Sep 2020 20:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600113781; bh=l4Q4WPuEytbe/ZhzYL6FNXk2+70d3f/3OC4oKlTk4zA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0JSe+BRQnuBv9MknhqUcoIWiIpdTzU2B5ghDLqRhoYOujklgzUCKnb+onVuFSSefW r2lpUr1U/uIgk6W06goftBPLsMY/Q8Xp/4ZvmCFni+w8B2Xj4mAGXixYnbRsXjzwvQ qoFgKuL6vgVD8Z8GCq7T2NMhBBp8XAPZPGkEDPbM= Date: Mon, 14 Sep 2020 13:02:59 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: David Miller , luojiaxing@huawei.com, idos@mellanox.com, ogerlitz@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit() Message-ID: <20200914130259.6b0e2ec6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <1599898095-10712-1-git-send-email-luojiaxing@huawei.com> <20200912.182219.1013721666435098048.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 13 Sep 2020 13:12:05 +0300 Tariq Toukan wrote: > 2. When MLX4_EN_PERF_STAT is not defined, we should totally remove the > local variable declaration, not only its usage. I was actually wondering about this when working on the pause stat patch. Where is MLX4_EN_PERF_STAT ever defined? $ git grep MLX4_EN_PERF_STAT drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:#ifdef MLX4_EN_PERF_STAT drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:#endif /* MLX4_EN_PERF_STAT */ drivers/net/ethernet/mellanox/mlx4/mlx4_stats.h:#ifdef MLX4_EN_PERF_STAT