Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Sep 2020 13:07:05 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Oded Gabbay <oded.gabbay@gmail.com>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, SW_Drivers@habana.ai,
        gregkh@linuxfoundation.org, davem@davemloft.net,
        f.fainelli@gmail.com, Omer Shpigelman <oshpigelman@habana.ai>
Subject: Re: [PATCH v2 12/14] habanalabs/gaudi: Add ethtool support using
 coresight
Message-ID: <20200914130705.45d2b61d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200914012413.GB3463198@lunn.ch>
References: <20200912144106.11799-1-oded.gabbay@gmail.com>
        <20200912144106.11799-13-oded.gabbay@gmail.com>
        <20200914012413.GB3463198@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 14 Sep 2020 03:24:13 +0200 Andrew Lunn wrote:
> > +static void gaudi_nic_get_internal_stats(struct net_device *netdev, u64 *data)
> > +{
> > +	struct gaudi_nic_device **ptr = netdev_priv(netdev);
> > +	struct gaudi_nic_device *gaudi_nic = *ptr;
> > +	struct hl_device *hdev = gaudi_nic->hdev;
> > +	u32 port = gaudi_nic->port;
> > +	u32 num_spmus;
> > +	int i;
> > +
> > +	num_spmus = (port & 1) ? NIC_SPMU1_STATS_LEN : NIC_SPMU0_STATS_LEN;
> > +
> > +	gaudi_sample_spmu_nic(hdev, port, num_spmus, data);
> > +	data += num_spmus;
> > +
> > +	/* first entry is title */
> > +	data[0] = 0;  
> 
> You have been looking at statistics names recently. What do you think
> of this data[0]?

Highly counter-productive, users will commonly grep for statistics.
Header which says "TX stats:" is a bad idea.