Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Sep 2020 22:29:25 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        "Frank Ch. Eigler" <fche@redhat.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 09/26] perf tools: Try load vmlinux from buildid database
Message-ID: <20200914202925.GU1714160@krava>
References: <20200913210313.1985612-1-jolsa@kernel.org>
 <20200913210313.1985612-10-jolsa@kernel.org>
 <CAM9d7ch7TqHr8dwCQ3_OZjpvp4yv+u=ipdDJR=AcCdUb2zSw2Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM9d7ch7TqHr8dwCQ3_OZjpvp4yv+u=ipdDJR=AcCdUb2zSw2Q@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 14, 2020 at 03:25:39PM +0900, Namhyung Kim wrote:
> On Mon, Sep 14, 2020 at 6:04 AM Jiri Olsa <jolsa@kernel.org> wrote:
> >
> > Currently we don't check on kernel's vmlinux the same way as
> > we do for normal binaries, but we either look for kallsyms
> > file in build id database or check on known vmlinux locations
> > (plus some other optional paths).
> >
> > This patch adds the check for standard build id binary location,
> > so we are ready once we start to store it there from debuginfod
> > in following changes.
> 
> But dso__load_vmlinux_path() already has the logic.
> Also you should check symbol_conf.ignore_vmlinux_buildid.

I wanted to have it not dependent on !symbol_conf.ignore_vmlinux
which is needed to call dso__load_vmlinux_path

also the idea was to try the build id vmlinux before the configured
vmlinux locations, because they found the vmlinux in my setup ;-)

I'll double check the logic again

thanks,
jirka