Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791AbWEaTuw (ORCPT ); Wed, 31 May 2006 15:50:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751789AbWEaTuw (ORCPT ); Wed, 31 May 2006 15:50:52 -0400 Received: from dbl.q-ag.de ([213.172.117.3]:52900 "EHLO dbl.q-ag.de") by vger.kernel.org with ESMTP id S1751788AbWEaTuv (ORCPT ); Wed, 31 May 2006 15:50:51 -0400 Message-ID: <447DF38E.3020409@colorfullife.com> Date: Wed, 31 May 2006 21:50:38 +0200 From: Manfred Spraul User-Agent: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.13) Gecko/20060501 Fedora/1.7.13-1.1.fc5 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Marcelo Tosatti CC: Willy Tarreau , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Ayaz Abdulla Subject: Re: [PATCH-2.4] forcedeth update to 0.50 References: <20060530220319.GA6945@w.ods.org> <447D2EA8.8020001@colorfullife.com> <20060531055438.GA9142@w.ods.org> <20060531180545.GA30797@dmt> In-Reply-To: <20060531180545.GA30797@dmt> Content-Type: multipart/mixed; boundary="------------010604090908050001060806" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1570 Lines: 49 This is a multi-part message in MIME format. --------------010604090908050001060806 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Marcelo Tosatti wrote: >Since v2.4.33 should be out RSN, my opinion is that applying the one-liner >to fix the bringup problem for now is more prudent.. > > > It's attached. Untested, but it should work. Just the relevant hunk from the 0.42 patch. But I would disagree with waiting for 2.3.34 for a full backport: 0.30 basically doesn't work, thus the update to 0.50 would be a big step forward - it can't be worse that 0.30. -- Manfred --------------010604090908050001060806 Content-Type: text/plain; name="patch-forcedeth-minimal" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch-forcedeth-minimal" --- 2.6/drivers/net/forcedeth.c 2005-08-14 11:17:03.000000000 +0200 +++ build-2.6/drivers/net/forcedeth.c 2005-08-14 11:16:53.000000000 +0200 @@ -2178,6 +2180,9 @@ writel(NVREG_MIISTAT_MASK, base + NvRegMIIStatus); dprintk(KERN_INFO "startup: got 0x%08x.\n", miistat); } + /* set linkspeed to invalid value, thus force nv_update_linkspeed + * to init hw */ + np->linkspeed = 0; ret = nv_update_linkspeed(dev); nv_start_rx(dev); nv_start_tx(dev); --------------010604090908050001060806-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/