Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200911143022.414783-1-nicolas.rybowski@tessares.net> <20200911143022.414783-3-nicolas.rybowski@tessares.net>
In-Reply-To: <20200911143022.414783-3-nicolas.rybowski@tessares.net>
From:   Song Liu <song@kernel.org>
Date:   Mon, 14 Sep 2020 14:00:47 -0700
Message-ID: <CAPhsuW7Qk8bea0efQspCOBbBaahgYt5eebvwvnGrA3xz9tw1Tg@mail.gmail.com>
Subject: Re: [PATCH bpf-next v2 3/5] bpf: add 'bpf_mptcp_sock' structure and helper
To:     Nicolas Rybowski <nicolas.rybowski@tessares.net>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        Andrii Nakryiko <andriin@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Mat Martineau <mathew.j.martineau@linux.intel.com>,
        Matthieu Baerts <matthieu.baerts@tessares.net>,
        open list <linux-kernel@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        mptcp@lists.01.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 11, 2020 at 8:15 AM Nicolas Rybowski
<nicolas.rybowski@tessares.net> wrote:
>
> In order to precisely identify the parent MPTCP connection of a subflow,
> it is required to access the mptcp_sock's token which uniquely identify a
> MPTCP connection.
>
> This patch adds a new structure 'bpf_mptcp_sock' exposing the 'token' field
> of the 'mptcp_sock' extracted from a subflow's 'tcp_sock'. It also adds the
> declaration of a new BPF helper of the same name to expose the newly
> defined structure in the userspace BPF API.
>
> This is the foundation to expose more MPTCP-specific fields through BPF.
>
> Currently, it is limited to the field 'token' of the msk but it is
> easily extensible.
>
> Acked-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> Acked-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> Signed-off-by: Nicolas Rybowski <nicolas.rybowski@tessares.net>

Acked-by: Song Liu <songliubraving@fb.com>