Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Sep 2020 18:51:55 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        "Frank Ch. Eigler" <fche@redhat.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 05/26] perf tools: Add build_id__is_defined function
Message-ID: <20200914215155.GG166601@kernel.org>
References: <20200913210313.1985612-1-jolsa@kernel.org>
 <20200913210313.1985612-6-jolsa@kernel.org>
 <CAM9d7cjjGjTN8sDgLZ1PoQZ-sUXWjnVaNdyOVE1yHxq46PrPkw@mail.gmail.com>
 <20200914204701.GZ1714160@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200914204701.GZ1714160@krava>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Mon, Sep 14, 2020 at 10:47:01PM +0200, Jiri Olsa escreveu:
> On Mon, Sep 14, 2020 at 02:44:35PM +0900, Namhyung Kim wrote:
> > On Mon, Sep 14, 2020 at 6:05 AM Jiri Olsa <jolsa@kernel.org> wrote:
> > >
> > > Adding build_id__is_defined helper to check build id
> > > is defined and is != zero build id.
> > >
> > > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > > ---
> > >  tools/perf/util/build-id.c | 11 +++++++++++
> > >  tools/perf/util/build-id.h |  1 +
> > >  2 files changed, 12 insertions(+)
> > >
> > > diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
> > > index 31207b6e2066..bdee4e08e60d 100644
> > > --- a/tools/perf/util/build-id.c
> > > +++ b/tools/perf/util/build-id.c
> > > @@ -902,3 +902,14 @@ bool perf_session__read_build_ids(struct perf_session *session, bool with_hits)
> > >
> > >         return ret;
> > >  }
> > > +
> > > +bool build_id__is_defined(const u8 *build_id)
> > > +{
> > > +       static u8 zero[BUILD_ID_SIZE];
> > > +       int err = 0;
> > > +
> > > +       if (build_id)
> > > +               err = memcmp(build_id, &zero, BUILD_ID_SIZE);
> > > +
> > > +       return err ? true : false;
> > > +}
> > 
> > I think this is a bit confusing.. How about this?
> > 
> >   bool ret = false;
> >   if (build_id)
> >       ret = memcmp(...);
> >   return ret;
> 
> ok
> 
> > 
> > Or, it can be a oneliner..
> 
> everything can be oneliner ;-)

But has to pass checkpatch.pl, so no more than 80 chars.

;-)

- Arnaldo