Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2509136pxk; Mon, 14 Sep 2020 15:45:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaMQ3VKyKq0I/ap/AiAbbmI0ElTWpMpu9OmpjOFGApRNXJjTKkkw+tsqM3eaUX7y0+BOyY X-Received: by 2002:a50:fc83:: with SMTP id f3mr18913211edq.256.1600123531673; Mon, 14 Sep 2020 15:45:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600123531; cv=none; d=google.com; s=arc-20160816; b=COIgENsuRsW42Ha0oHXRURe7IBkA6FGgUcqksmgsrF3I+GWbg5hozc8Q5rPPp6mgW4 8ykfCMNnskXIq8PjOr8ZMVP0Q5W4SyBrRbGJ6MJ1y9gI6smiypHAKKCHRqtcTvtpJ2ZK thFWZ3NOdUNgNGeAutfA48pYjbX+sYSxQCQHVnxcBU/DA2EB2eAXunZztIMI5hfAN+Y1 ZHQy8PTy/VyB+w1u+Cp0YHGUQrlsmoKakMc3u3fkYZzAlTf8GPhz2oJ8AW3ECKRvzNlS Z+xTTGu8oXCRdCQC8G3Cn+UKaCw3NniaLDSNnfhbm94rb5i7KCXm5QL788sJ72s0kRl1 i1lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=vg9QjBJY9w2CXGkLGGWzp1D6RTNIkXIXRlX2lJrHsAA=; b=IQmV2+GvYY0MBSrVJfqL7LRb59OZrW7P/Vl73IU6jYU86nOVD4tU4D3Xb/FCZ+kV0Q oJroVpx093zwoHsIFo1sOE6ee19rAsUIoaHHI4QyVWJI1aawQgyLPdZZ5sDXaypCQyg4 kXtDgZqPajUkWCMc+FnFo3KKIIPQYk+z7Nn1GmY7C8EMbozRgwoTtl3JG2pZ5gO8bUbP UGJcDNFFe0hK3v5I8J5y87SJeyXRFdGcqjpD/ArsR4xB50mPzSS/+1798CK5AUdctQBx ScSepEQEeYnA3u2BVg0EwlkOOM+00m1O6vCcsPXKt93wk18cqDvh30AzJvjV/C4SDuz8 nUnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qp7si7949100ejb.550.2020.09.14.15.45.09; Mon, 14 Sep 2020 15:45:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726019AbgINWnN (ORCPT + 99 others); Mon, 14 Sep 2020 18:43:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:34036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbgINWnM (ORCPT ); Mon, 14 Sep 2020 18:43:12 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B108C20732; Mon, 14 Sep 2020 22:43:10 +0000 (UTC) Date: Mon, 14 Sep 2020 18:43:09 -0400 From: Steven Rostedt To: Tingwei Zhang Cc: Tingwei Zhang , Ingo Molnar , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , tsoni@codeaurora.org, Sai Prakash Ranjan , Mao Jinlong , linux-kernel@vger.kernel.org, coresight@lists.linaro.org Subject: Re: [PATCH v3 0/6] tracing: export event trace and trace_marker Message-ID: <20200914184309.7a9de53a@gandalf.local.home> In-Reply-To: <20200901232839.GB13346@codeaurora.org> References: <20200813014552.23539-1-tingwei@codeaurora.org> <20200901232839.GB13346@codeaurora.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Sep 2020 07:28:39 +0800 Tingwei Zhang wrote: > Hi Alexander, > > May I know your comments for this patch set? I ran your patch set against get_maintainers.pl and it came up with this: Alexander Shishkin (maintainer:SYSTEM TRACE MODULE CLASS) Maxime Coquelin (maintainer:ARM/STM32 ARCHITECTURE) Alexandre Torgue (maintainer:ARM/STM32 ARCHITECTURE) Steven Rostedt (maintainer:TRACING) Ingo Molnar (maintainer:TRACING) linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32 ARCHITECTURE) linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32 ARCHITECTURE) linux-kernel@vger.kernel.org (open list) I would use that to know who to send to. You have Alexander, myself, Ingo and LKML, but you should add the others in that list for this series, and then it may get noticed. Please use get_maintainers.pl for future patches if you don't know who to send them to. -- Steve > > Thanks, > Tingwei > > On Thu, Aug 13, 2020 at 09:45:46AM +0800, Tingwei Zhang wrote: > > Ftrace has ability to export trace packets to other destination. > > Currently, only function trace can be exported. This series extends the > > support to event trace and trace_maker. STM is one possible destination to > > export ftrace. Use separate channel for each CPU to avoid mixing up > > packets > > from different CPUs together. > > > > Change from v2: > > Change flag definition to BIT(). (Steven) > > Add comment in stm_ftrace_write() to clarify it's safe to use > > smp_processor_id() here since preempt is disabled. (Steven) > > > > Change from v1: > > All changes are suggested by Steven Rostedt. > > User separate flag to control function trace, event trace and trace mark. > > Allocate channels according to num_possible_cpu() dynamically. > > Move ftrace_exports routines up so all ftrace can use them. > > > > Tingwei Zhang (6): > > stm class: ftrace: change dependency to TRACING > > tracing: add flag to control different traces > > tracing: add trace_export support for event trace > > tracing: add trace_export support for trace_marker > > stm class: ftrace: enable supported trace export flag > > stm class: ftrace: use different channel accroding to CPU > > > > drivers/hwtracing/stm/Kconfig | 2 +- > > drivers/hwtracing/stm/ftrace.c | 7 +- > > include/linux/trace.h | 7 + > > kernel/trace/trace.c | 270 ++++++++++++++++++--------------- > > 4 files changed, 159 insertions(+), 127 deletions(-) > > > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > > a Linux Foundation Collaborative Project > >