Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200909084942.2122349-1-yukuai3@huawei.com>
In-Reply-To: <20200909084942.2122349-1-yukuai3@huawei.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Tue, 15 Sep 2020 07:38:51 +0800
Message-ID: <CAAOTY__OPKHd+=WD_nfPJVbXh8As8CDi=tGzbMAtxBQXbzjQYg@mail.gmail.com>
Subject: Re: [PATCH] drm/mediatek: add exception handing in mtk_drm_probe() if
 component init fail
To:     Yu Kuai <yukuai3@huawei.com>
Cc:     Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        CK Hu <ck.hu@mediatek.com>,
        Bibby Hsieh <bibby.hsieh@mediatek.com>, yt.shen@mediatek.com,
        djkurtz@chromium.org, littlecvr@chromium.org,
        DRI Development <dri-devel@lists.freedesktop.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>, yi.zhang@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Yu Kuai:

Yu Kuai <yukuai3@huawei.com> =E6=96=BC 2020=E5=B9=B49=E6=9C=889=E6=97=A5 =
=E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=884:50=E5=AF=AB=E9=81=93=EF=BC=9A
>
> mtk_ddp_comp_init() is called in a loop in mtk_drm_probe(), if it
> fail, previous successive init component is not proccessed.
>
> Thus uninitialize valid component and put their device if component
> init failed.

Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>

>
> Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT817=
3.")
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/med=
iatek/mtk_drm_drv.c
> index 040a8f393fe2..75a6cf231fd7 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -544,8 +544,13 @@ static int mtk_drm_probe(struct platform_device *pde=
v)
>         pm_runtime_disable(dev);
>  err_node:
>         of_node_put(private->mutex_node);
> -       for (i =3D 0; i < DDP_COMPONENT_ID_MAX; i++)
> +       for (i =3D 0; i < DDP_COMPONENT_ID_MAX; i++) {
>                 of_node_put(private->comp_node[i]);
> +               if (private->ddp_comp[i]) {
> +                       put_device(private->ddp_comp[i]->larb_dev);
> +                       private->ddp_comp[i] =3D NULL;
> +               }
> +       }
>         return ret;
>  }
>
> --
> 2.25.4
>