Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Sep 2020 17:03:21 -0700 (PDT)
Message-Id: <20200914.170321.1710628974878239639.davem@davemloft.net>
To:     mfwitten@gmail.com
Cc:     sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] openprom: Fix 'opiocnextprop'; ensure integer
 conversions; use string size
From:   David Miller <davem@davemloft.net>
In-Reply-To: <a5515efeaad94666a87f264dbf65bdbd@gmail.com>
References: <a5515efeaad94666a87f264dbf65bdbd@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Michael Witten <mfwitten@gmail.com>
Date: Fri, 04 Sep 2020 19:40:00 -0000

> @@ -34,10 +34,10 @@ EXPORT_SYMBOL(of_console_options);
>  int of_getintprop_default(struct device_node *np, const char *name, int def)
>  {
>  	struct property *prop;
> -	int len;
> +	int size;
>  
> -	prop = of_find_property(np, name, &len);
> -	if (!prop || len != 4)
> +	prop = of_find_property(np, name, &size);
> +	if (!prop || size != 4)
>  		return def;

This is just changing the variable name and makes no functional change
at all, and therefore is gratuitous.

Please only include pure functional changes that fix the bug(s) in
question.

If there are multiple bugs, please fix one bug per patch and include a
detailed explanation of each bug fix in the body of the commit
message.

Thank you.