Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Alistair Popple <apopple@nvidia.com>
To:     <linux-mm@kvack.org>
CC:     Jason Gunthorpe <jgg@ziepe.ca>, Jonathan Corbet <corbet@lwn.net>,
        "Ralph Campbell" <rcampbell@nvidia.com>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        =?ISO-8859-1?Q?J=E9r=F4me?= Glisse <jglisse@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/doc: add usage description for migrate_vma_*()
Date:   Tue, 15 Sep 2020 11:05:10 +1000
Message-ID: <2077765.OaWJzLOgzI@nvdebian>
In-Reply-To: <20200910172514.GN87483@ziepe.ca>
References: <20200909212956.20104-1-rcampbell@nvidia.com> <20200910105657.6007c5ca@lwn.net> <20200910172514.GN87483@ziepe.ca>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Friday, 11 September 2020 3:25:14 AM AEST Jason Gunthorpe wrote:
> On Thu, Sep 10, 2020 at 10:56:57AM -0600, Jonathan Corbet wrote:
> > On Wed, 9 Sep 2020 14:29:56 -0700
> > 
> > Ralph Campbell <rcampbell@nvidia.com> wrote:
> > > The migrate_vma_setup(), migrate_vma_pages(), and migrate_vma_finalize()
> > > API usage by device drivers is not well documented.
> > > Add a description for how device drivers are expected to use it.
> > > 
> > > Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> > > 
> > > There shouldn't be any merge conflict with my previous patch which
> > > touched hmm.rst but since Jonathan Corbet took my last patch, perhaps he
> > > would like to take this one through his tree too.
> > 
> > I'm happy to take it, but it certainly needs an ack from somebody who
> > understands HMM better than I do.
> 
> Ralph wrote all the in kernel tests for this API, so I think he is
> well positioned to write the documentation :)

I have recently read through most of the code to get back up to date with 
recent HMM developments and the documentation here didn't conflict with my 
understanding based on the code. The description of pgmap_owner is good as 
it's usage wasn't immediately clear on the first code read through. So feel 
free to add:

Reviewed-by: Alistair Popple <apopple@nvidia.com>
 
> Jason