Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2582182pxk; Mon, 14 Sep 2020 18:18:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7ofZY1899dnq+sCECe+u4YC0h25lrfxKoy/iJ5rOYtHHk0W8iCkCtlukQy8ef6BYezY2p X-Received: by 2002:a05:6402:cb4:: with SMTP id cn20mr20105150edb.369.1600132705972; Mon, 14 Sep 2020 18:18:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600132705; cv=none; d=google.com; s=arc-20160816; b=l1swOU5E0wBiuI1/urzeOw+jXJJKLsHuwIiZUiJqdu8P4cSoSydnE/+e+88I6otBI1 w80WOOyzq/tTNvWTHLQYWC7Gldxq0APBkoAXYkFSCQXUUhgpDVNuQm7B2zAY8wmy1WUN 2kBhpwuFTbcxnXdm29S2qmuK3Uy5U5MHqvaDrtQjkTnzaxrjkmOhqjBgK1UDAi2snyNn 2LS8/GMurEIJg8bxjq47JYYXMIcnGwAL8I84kInY+FY4l72AXszNP2wKjAKMR4k1uHdN aRbXR2fFidRbQLoXDV2mllDGgZf4xJhbxr1aineYxuGdXmQFaX2Ix7y8nJBDcXTPNxFU g+RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Kbg1eHGtOQnYQ+M/Y2pvYX5z74YhXGuuRyeYjR/TpSM=; b=Mz3EJNdRiHyJmt/keJJetERssqkSstxerhlfxguABN1z2jStr0QAw3MIf2HIA3Bfa4 SplIMdxc6oMU8gpGUiyZgdzSJv39XWIJHbXHVaA1nieY1kx6R7ZC8kr7/LNStwZc7GWX Ogo1Neo2Dp0dyc7UYulOQItj4awtkL2naKfUswefIYArTzuf+rQu4OF5MwzjZp17fHI5 jIUYmqxdsZPMVzBhTrsh46D9OlxDO/pqj0a6T/GcB4+jxl64HgFcMWfc2jfrAfRsaQU6 H4uKVAxBe8pSkTjD9ArYPMsrYGpjjX1s2if2LPAQLHKG6q6np8ONV1hfrk0yR3ZHsSSr Bcgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p25si8362417edw.585.2020.09.14.18.18.03; Mon, 14 Sep 2020 18:18:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726061AbgIOBQc (ORCPT + 99 others); Mon, 14 Sep 2020 21:16:32 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:38214 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbgIOBQa (ORCPT ); Mon, 14 Sep 2020 21:16:30 -0400 Received: by mail-io1-f66.google.com with SMTP id h4so2270009ioe.5; Mon, 14 Sep 2020 18:16:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Kbg1eHGtOQnYQ+M/Y2pvYX5z74YhXGuuRyeYjR/TpSM=; b=Qhq+Yonnpg5hgFuxsybXIg/yuZXj6IYvVOauycvhcMvQPWdXIfen6NNjlOdDvGGFyr H9XYlzQx7d7DRSBs0t6oSXvYJG/JhGPiwnm4lCMtKlwtcwjQV0xy3AYdNsQiKkcM90tL 9kDeuYdAGwe4SZchVX14mg5HoffiG2ePJbxZhiBStLl90HRJJmYUHiG5n7138THg9ig3 GGMD4mWSPsxbir0RaU5ZFKfVX4MYmLUZ97oPAe6tah8wmrKGjlaxJI68GtppRqzBAKgn 8h1V/iFcQ/y1a2nEQQzwT/6CiwVsWQAM9QtxJFRpzyswL+CNCm5cc75s/e7bMOC7V2En FEKw== X-Gm-Message-State: AOAM5310vIAI60MBh+wFtn65y748LufiopPrhb15e6ITxI7AnBmQk72H r2Otfx+YE8/7NMrxbnZ/ep6IOcnw50Ug X-Received: by 2002:a6b:c953:: with SMTP id z80mr13381128iof.178.1600132589539; Mon, 14 Sep 2020 18:16:29 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id d23sm6861698ioh.22.2020.09.14.18.16.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 18:16:28 -0700 (PDT) Received: (nullmailer pid 645148 invoked by uid 1000); Tue, 15 Sep 2020 01:16:25 -0000 Date: Mon, 14 Sep 2020 19:16:25 -0600 From: Rob Herring To: Zhiqiang Hou Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, shawnguo@kernel.org, leoyang.li@nxp.com, lorenzo.pieralisi@arm.com, gustavo.pimentel@synopsys.com, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com Subject: Re: [PATCH 1/7] PCI: dwc: Fix a bug of the case dw_pci->ops is NULL Message-ID: <20200915011625.GA640859@bogus> References: <20200907053801.22149-1-Zhiqiang.Hou@nxp.com> <20200907053801.22149-2-Zhiqiang.Hou@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200907053801.22149-2-Zhiqiang.Hou@nxp.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2020 at 01:37:55PM +0800, Zhiqiang Hou wrote: > From: Hou Zhiqiang > > The dw_pci->ops may be a NULL, and fix it by adding one more check. > > Signed-off-by: Hou Zhiqiang > --- > drivers/pci/controller/dwc/pcie-designware.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Rob Herring Note that this may conflict with my 40 patch clean-up series. Rob