Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2626166pxk; Mon, 14 Sep 2020 20:05:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5ZbsZLbJdw9s9h625BknHOn9upmMGDgTMpJWDCYJX+p2ih+ItQOzPPIog0yJlFrAG8ppr X-Received: by 2002:a17:906:d182:: with SMTP id c2mr17528522ejz.378.1600139112814; Mon, 14 Sep 2020 20:05:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600139112; cv=none; d=google.com; s=arc-20160816; b=m6lWgh4gShuK+TuLcaC6ICoxGAy9dBKWR6s0wA5yrgJ6/pKMpp9uw2+DguEp7cHHW9 DggltnBKII+lmdMezcXOFXSW6r7u9WAQ6SDMxV12RERV+08SLG3km4I8RA3ck7TUyV0u SB9nkbBpcl7YoIvGX2Tb/gdd+ULi0h4jUuklSa78jIvoezmFk9TwL8WUOnU+uJwWAH44 g/AOtGTGUlboncPYVjqvXERSDmH7OyoeSwHxowpAzltkO7Vq970RHSVW3fCThARN7rAR I6eK/FcXKQfbRblG5+iA63IGu0Qp1HKe/LO3Nz7jNFKSbc7rDPo7jMGRWTSLvBqiTu5F 94Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=dCKBAFjxGBfz4ceAQLd7oNHM8wvQkG17IT2FjwStnZ8=; b=XhfsTmgbjNEBZpITjZzIiUnyDIzwSlDt2l9Hp2FEYRwuCSfeFM+g6BPaZPRxr82rj8 fNS2mahJ3XVtlfmTPrMfDvDV+n8p+qJtmJWWsJgb97gzTWyN5lgJGKrkUcWiivHG7QA/ 3F+UFPbYUDiXL2CVI/czutJmsCBBCVSwvUoTByrvByvY3IW8G3lO1TjJkY6VULqR8fSX avjNlmAw6XF87SOxMImYHvC+qrfi9ZUc5U/UkWeT1qwyTndzZmgNXywcgZV2v6DwIkgr 6TKLdYx4ibxmtjubRUJ49MM6YAHnNLwufsbuTce/GGrKxZGXGUtzYZdHvkygzvHAnGns stRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q6si8038052ejx.221.2020.09.14.20.04.50; Mon, 14 Sep 2020 20:05:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726149AbgIODEH (ORCPT + 99 others); Mon, 14 Sep 2020 23:04:07 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:12282 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726045AbgIODD4 (ORCPT ); Mon, 14 Sep 2020 23:03:56 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 12998763F03EE3FFA957; Tue, 15 Sep 2020 11:03:54 +0800 (CST) Received: from huawei.com (10.175.113.32) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Tue, 15 Sep 2020 11:03:43 +0800 From: Liu Shixin To: Bartlomiej Zolnierkiewicz , Jens Axboe CC: , , Liu Shixin Subject: [PATCH -next] ata: pata_samsung_cf: simplify the return expression of pata_s3c_wait_after_reset() Date: Tue, 15 Sep 2020 11:26:21 +0800 Message-ID: <20200915032621.1772254-1-liushixin2@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.32] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simplify the return expression. Signed-off-by: Liu Shixin --- drivers/ata/pata_samsung_cf.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c index 3da0e8e30286..5fd5c79e1543 100644 --- a/drivers/ata/pata_samsung_cf.c +++ b/drivers/ata/pata_samsung_cf.c @@ -340,19 +340,14 @@ static unsigned int pata_s3c_devchk(struct ata_port *ap, static int pata_s3c_wait_after_reset(struct ata_link *link, unsigned long deadline) { - int rc; - ata_msleep(link->ap, ATA_WAIT_AFTER_RESET); - /* always check readiness of the master device */ - rc = ata_sff_wait_ready(link, deadline); - /* -ENODEV means the odd clown forgot the D7 pulldown resistor + /* + * always check readiness of the master device. + * -ENODEV means the odd clown forgot the D7 pulldown resistor * and TF status is 0xff, bail out on it too. */ - if (rc) - return rc; - - return 0; + return ata_sff_wait_ready(link, deadline); } /* -- 2.25.1