Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2638775pxk; Mon, 14 Sep 2020 20:35:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwveWjUN26HC4lZ6ctyfMI8Je35s225/NKiC7O3nZlcaCajcZWPq6ekwsARs18UszEiqyXy X-Received: by 2002:a50:99d5:: with SMTP id n21mr20389806edb.88.1600140904405; Mon, 14 Sep 2020 20:35:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600140904; cv=none; d=google.com; s=arc-20160816; b=xb2Ixec1FN1ldKbZ+/GDxE4cu1Hnih+F/Bc0kDCyprM1pptH8V3l22lV1k7xe7c6Z5 CTLqbaOIckvxtMfFquiF/VhKiVeOL93uSuGxfZTx2OibzXQ6abJFK1sKC3ghEbYThRvM 27MfBrSYmbDr8YmGjU+jG6xVJC9s8OHnCw09mXaeaR/Q+K0OUR1gbSiPhzMxGaVtAUYC Xczg/J3GZGYZWadSVw/0CdaQLtrBQ7NGDJy9mUuSl9icQOyh57ud4xjVkaa2RS2aq+Bf uJiUthUcyPWZbS4tcyB5E1SalZikBbs7SWMeKsFMGo2PJDohuL02ei52Tthh8EPDGsSs nvpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=cHzGXT8HEqH82R9kUwujLcg1lAqVnO6cUV58kZSVATw=; b=H9L4w+DU8leybMCM5aW93n459D9l781vG2oonuhv17+cV3eNk+tub5Vw/KXf+cM+0x zgCVXovDs/5q/S4FPFb5b+O2XLFnT6plgAMZ3RJpXlKb8/tkMKATo9HZKplYjxaen7zv J3OjC1ci7dByUXsFumAlNAOJOmIrbLMhbSRQNxD5mcTZS4W4DVG4sglFZesKbfr/pQVF 4hJT9p82z/5kiaxTuFdZKN0PeN3yWwUiNvIt39zycqbH+s02iWV7FjcJhXgF6tClrseS A/ltPeSzFLAtL60CTZHqbl4wwg30ZWrisweegAkGHpO/cJ4Tq9tEk5Pzj6gNO5RSecC/ 8r+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f24si9021079edr.375.2020.09.14.20.34.41; Mon, 14 Sep 2020 20:35:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726158AbgIODcx (ORCPT + 99 others); Mon, 14 Sep 2020 23:32:53 -0400 Received: from mga05.intel.com ([192.55.52.43]:64033 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726123AbgIODci (ORCPT ); Mon, 14 Sep 2020 23:32:38 -0400 IronPort-SDR: qoBifkpCd00ua3pOnu4gwZqX7MGccjXZZN+2bgB2a8jbLAwPO3ZuLOnehXAo9dBVi3zHHb8EB9 SUkvN6326TNA== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="244026455" X-IronPort-AV: E=Sophos;i="5.76,428,1592895600"; d="scan'208";a="244026455" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 20:32:37 -0700 IronPort-SDR: JWajAGiUSfOXtLD5k0IW0CxCtulIWZ//bqKc9e8R9HqMK9JefVT/ig6ZhK8VpN2C9GNJV+A9ui hQ5X7u8+jZpg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,428,1592895600"; d="scan'208";a="482596431" Received: from yilunxu-optiplex-7050.sh.intel.com ([10.239.159.141]) by orsmga005.jf.intel.com with ESMTP; 14 Sep 2020 20:32:36 -0700 From: Xu Yilun To: mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, masahiroy@kernel.org Cc: trix@redhat.com, lgoncalv@redhat.com, Xu Yilun Subject: [PATCH v2 3/4] fpga: dfl: fix the comments of type & feature_id fields Date: Tue, 15 Sep 2020 11:27:52 +0800 Message-Id: <1600140473-12351-4-git-send-email-yilun.xu@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1600140473-12351-1-git-send-email-yilun.xu@intel.com> References: <1600140473-12351-1-git-send-email-yilun.xu@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The description of feature_id in struct dfl_device is not accurate. In DFL specification the feature_id is the 12 bits field. The description in struct dfl_device_id is more clear so we make them aligned. We also made the similar fix for the type field. Signed-off-by: Xu Yilun --- drivers/fpga/dfl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h index 3c69596..d5e050a 100644 --- a/drivers/fpga/dfl.h +++ b/drivers/fpga/dfl.h @@ -531,8 +531,8 @@ enum dfl_id_type { * * @dev: generic device interface. * @id: id of the dfl device. - * @type: type of DFL FIU of the device. See enum dfl_id_type. - * @feature_id: 16 bits feature identifier local to its DFL FIU type. + * @type: contains 4 bits DFL FIU type of the device. See enum dfl_id_type. + * @feature_id: contains 12 bits feature identifier local to its DFL FIU type. * @mmio_res: mmio resource of this dfl device. * @irqs: list of Linux IRQ numbers of this dfl device. * @num_irqs: number of IRQs supported by this dfl device. -- 2.7.4