Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965143AbWEaVWh (ORCPT ); Wed, 31 May 2006 17:22:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965138AbWEaVWh (ORCPT ); Wed, 31 May 2006 17:22:37 -0400 Received: from smtp.osdl.org ([65.172.181.4]:52951 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S965093AbWEaVWg (ORCPT ); Wed, 31 May 2006 17:22:36 -0400 Date: Wed, 31 May 2006 14:25:25 -0700 From: Andrew Morton To: Arjan van de Ven Cc: pauldrynoff@gmail.com, linux-kernel@vger.kernel.org, mingo@elte.hu Subject: Re: 2.6.17-rc5-mm1 - output of lock validator Message-Id: <20060531142525.5a22f9f1.akpm@osdl.org> In-Reply-To: <447DFE29.6040508@linux.intel.com> References: <20060530195417.e870b305.pauldrynoff@gmail.com> <20060530132540.a2c98244.akpm@osdl.org> <20060531181926.51c4f4c5.pauldrynoff@gmail.com> <1149085739.3114.34.camel@laptopd505.fenrus.org> <20060531102128.eb0020ad.akpm@osdl.org> <447DFE29.6040508@linux.intel.com> X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 907 Lines: 26 Arjan van de Ven wrote: > > Andrew Morton wrote: > > On Wed, 31 May 2006 16:28:59 +0200 > > Arjan van de Ven wrote: > > > >> --- linux-2.6.17-rc5-mm1.5.orig/drivers/net/8390.c > >> +++ linux-2.6.17-rc5-mm1.5/drivers/net/8390.c > >> @@ -299,7 +299,7 @@ static int ei_start_xmit(struct sk_buff > >> > >> disable_irq_nosync(dev->irq); > >> > >> - spin_lock(&ei_local->page_lock); > >> + spin_lock_irqsave(&ei_local->page_lock, flags); > > > > Again, notabug - we did disable_irq(). > > but does disable_irq() work in the light of that irqpoll stuff? > Don't have a clue what you're referring to, sorry. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/