Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Piyush Mehta <piyushm@xilinx.com>
To:     Rob Herring <robh@kernel.org>
CC:     "axboe@kernel.dk" <axboe@kernel.dk>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        git <git@xilinx.com>, Srinivas Goud <sgoud@xilinx.com>,
        Michal Simek <michals@xilinx.com>
Subject: RE: [PATCH 2/2] dt-bindings: ata: achi: ceva: Update documentation
 for CEVA Controller
Thread-Topic: [PATCH 2/2] dt-bindings: ata: achi: ceva: Update documentation
 for CEVA Controller
Thread-Index: AQHWgPeT5Y9ogZmFGU6Ub+uc8cm3nKloo70AgACmkxA=
Date:   Tue, 15 Sep 2020 06:40:33 +0000
Message-ID: <BYAPR02MB397553291F489C01FC8C3A88D4200@BYAPR02MB3975.namprd02.prod.outlook.com>
References: <1599030348-3334-1-git-send-email-piyush.mehta@xilinx.com>
 <1599030348-3334-3-git-send-email-piyush.mehta@xilinx.com>
 <20200914200840.GA152914@bogus>
In-Reply-To: <20200914200840.GA152914@bogus>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 85cb2ca6-2ae4-4be8-fe55-08d859423f7f
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2020 06:40:33.9292
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: V+kZAq400TIwDTwcrhNMsIyc9coRrvWgA2pRKFK+oE5MlXPcHsEPl4NqFBhDu4bfHXv+tS2Tt8kw+cgzHg6IiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB3976
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Rob Herring,

Thanks for review.=20

Regards,
Piyush Mehta

-----Original Message-----
From: Rob Herring <robh@kernel.org>=20
Sent: Tuesday, September 15, 2020 1:39 AM
To: Piyush Mehta <piyushm@xilinx.com>
Cc: axboe@kernel.dk; p.zabel@pengutronix.de; linux-ide@vger.kernel.org; dev=
icetree@vger.kernel.org; linux-kernel@vger.kernel.org; git <git@xilinx.com>=
; Srinivas Goud <sgoud@xilinx.com>; Michal Simek <michals@xilinx.com>
Subject: Re: [PATCH 2/2] dt-bindings: ata: achi: ceva: Update documentation=
 for CEVA Controller

On Wed, Sep 02, 2020 at 12:35:48PM +0530, Piyush Mehta wrote:
> This patch updates the documentation for the CEVA controller for=20
> adding the required properties for 'phys' and 'resets'.
>=20
> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
> ---
>  Documentation/devicetree/bindings/ata/ahci-ceva.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt=20
> b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> index 7561cc4..f01d317 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> @@ -35,6 +35,10 @@ Required properties:
>  			ceva,pN-retry-params =3D /bits/ 16 <RIT RCT>;
>  			RIT:  Retry Interval Timer.
>  			RCT:  Rate Change Timer.
> +  - phys: phandle for the PHY device
> +  - phy-names: Should be "sata-phy"
> +  - resets: phandle to the reset controller for the SATA IP
> +  - reset-names: Should be "sata_rst".

The names here are rather pointless. You don't really need them if only
1 entry.

> =20
>  Optional properties:
>    - ceva,broken-gen2: limit to gen1 speed instead of gen2.
> @@ -56,4 +60,8 @@ Examples:
>  		ceva,p1-burst-params =3D /bits/ 8 <0x0A 0x08 0x4A 0x06>;
>  		ceva,p1-retry-params =3D /bits/ 16 <0x0216 0x7F06>;
>  		ceva,broken-gen2;
> +		phy-names =3D "sata-phy";
> +		phys =3D <&psgtr 1 PHY_TYPE_SATA 1 1>;
> +		reset-names =3D "sata_rst";
> +		resets =3D <&zynqmp_reset ZYNQMP_RESET_SATA>;
>  	};
> --
> 2.7.4
>=20