Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kuldip Dwivedi <kuldip.dwivedi@puresoftware.com>
References: <20200911082806.115-1-kuldip.dwivedi@puresoftware.com>
 <HE1PR04MB31962FC006C6EB964AC2DAE895240@HE1PR04MB3196.eurprd04.prod.outlook.com>
 <20200911123428.GF4895@sirena.org.uk> <HE1PR04MB31961146633F7FE9EFE441A795240@HE1PR04MB3196.eurprd04.prod.outlook.com>
In-Reply-To: <HE1PR04MB31961146633F7FE9EFE441A795240@HE1PR04MB3196.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Thread-Index: AQK/xI2P7uxCBV5mjF/xjkF3M143zQKAOUTHAVgUksMCVmnJ7KdlWOrw
Date:   Tue, 15 Sep 2020 12:22:17 +0530
Message-ID: <6b704e53b0f31a2a74b35e477a330aac@mail.gmail.com>
Subject: RE: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
To:     Ashish Kumar <ashish.kumar@nxp.com>,
        Mark Brown <broonie@kernel.org>
Cc:     Yogesh Gaur <yogeshgaur.83@gmail.com>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, Varun Sethi <V.Sethi@nxp.com>,
        Arokia Samy <arokia.samy@nxp.com>,
        Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
        Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
        Paul Yang <Paul.Yang@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> -----Original Message-----
> From: Ashish Kumar <ashish.kumar@nxp.com>
> Sent: Friday, September 11, 2020 7:03 PM
> To: Mark Brown <broonie@kernel.org>
> Cc: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>; Yogesh Gaur
> <yogeshgaur.83@gmail.com>; linux-spi@vger.kernel.org; linux-
> kernel@vger.kernel.org; Varun Sethi <V.Sethi@nxp.com>; Arokia Samy
> <arokia.samy@nxp.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Samer
El-
> Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Paul Yang
> <Paul.Yang@arm.com>
> Subject: RE: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
>
> Hi Mark,
>
> > -----Original Message-----
> > From: Mark Brown <broonie@kernel.org>
> > Sent: Friday, September 11, 2020 6:04 PM
> > To: Ashish Kumar <ashish.kumar@nxp.com>
> > Cc: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>; Yogesh Gaur
> > <yogeshgaur.83@gmail.com>; linux-spi@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Varun Sethi <V.Sethi@nxp.com>; Arokia Samy
> > <arokia.samy@nxp.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Samer
> > El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Paul Yang
> > <Paul.Yang@arm.com>
> > Subject: Re: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
> >
> > On Fri, Sep 11, 2020 at 12:28:47PM +0000, Ashish Kumar wrote:
> > > > Signed-off-by: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
> >
> > > Please capture version change summary.
> > >
> > > Regards
> > > Ashish
> >
> > It's there:
> It did not mentioned about removing SWRST, which was present in v1.
> v2:Notes Looked very similar to v1.
Removed SWRST changes just to keep functionality same in ACP and DT mode,
I will post that change separately if It will be required. For tracking I
am adding this
point in notes
>
> Regards
> Ashish
> >
> > > >
> > > > Notes:
> > > >     1. Add ACPI match table, NXP members are added to confirm HID
> > > > for
> > FSPI
> > > >     2. Change the DT specific APIs to device property APIs
> > > >            so that same API can be used in DT and ACPi mode.
> > > >     3. Omit clock configuration part - in ACPI world, the firmware
> > > >            is responsible for clock maintenance.
> > > >     4. This patch is tested on LX2160A platform
5.  SWRST reset changes are removed from v1 as to keep functionality
same in ACP and DT mode, I will post that change separately if It will be
required