Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: FAPiLLD4PBHEY41i+N7WTrcq8d/IjnhYYy8H+mHy3eyy8zxMxrgKB3v/1vmA9899LHdkHqtes+
 YsYwC0IFR7Disz0IYfINOt+uV0Fl3myhclqQCLFZkKQv9FDfxMmyZOMm2J/ZCGWi2XPr58hjos
 ZhbljWJmQb1zy1/l1POcZ6EUM1AmRERk9B6QP1xKWrCbXDvRxk3zs4jt3ghQZOHo+gqSYP/XJK
 6Ahsemso03EnrJW9vNfxNF371jHNJQ621M0oyWpP9rqkyZeuj4O+RhbWyvRP9n4WXbH7M4oTFh
 BZA=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>
CC:     "cang@codeaurora.org" <cang@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        YueHaibing <yuehaibing@huawei.com>,
        Bean Huo <beanhuo@micron.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 2/2] scsi: ufs: Support reading UFS's Vcc voltage from
 device tree
Thread-Topic: [PATCH v1 2/2] scsi: ufs: Support reading UFS's Vcc voltage from
 device tree
Thread-Index: AQHWgCVjnykcytgHNk6DNhNz/3ZIoalmYjdggAIrSgCAAMrq0A==
Date:   Tue, 15 Sep 2020 06:51:35 +0000
Message-ID: <BY5PR04MB6705F57DAF788FAFDF71FFC4FC200@BY5PR04MB6705.namprd04.prod.outlook.com>
References: <cover.1598939393.git.nguyenb@codeaurora.org>
 <69db325a09d5c3fa7fc260db031b1e498b601c25.1598939393.git.nguyenb@codeaurora.org>
 <BY5PR04MB67051C08A73119B554E4F352FC220@BY5PR04MB6705.namprd04.prod.outlook.com>
 <170592eceb26da041f276cf4ca33aaf2@codeaurora.org>
In-Reply-To: <170592eceb26da041f276cf4ca33aaf2@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fa99e00-ae52-404b-57e2-08d85943c9e2
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2020 06:51:35.6545
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pHHSnPnANrBA4ftMmJSKvPXnAPEN5ozmhWDmwZI7CSeZGoY+EnuH8LIn+6cOEUYxrgAW3M8nZqBgiuMvYhSKdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4950
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > Maybe instead call ufshcd_populate_vreg with the new name,
> > To not break the function flow, and just add another else if ?
> Could you please clarify your comments? Are you suggesting to create a
> new function?
> Thank you.
No, just call ufshcd_populate_vreg with the new name, e.g. something like:

diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-plt=
frm.c
index 3db0af6..9798d4c 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
@@ -141,6 +141,8 @@ static int ufshcd_populate_vreg(struct device *dev, con=
st char *name,
                        vreg->min_uV =3D UFS_VREG_VCC_MIN_UV;
                        vreg->max_uV =3D UFS_VREG_VCC_MAX_UV;
                }
+       } else if (!strcmp(name, "vcc-voltage-level")) {
+               /* add your changes here */
        } else if (!strcmp(name, "vccq")) {
                vreg->min_uV =3D UFS_VREG_VCCQ_MIN_UV;
                vreg->max_uV =3D UFS_VREG_VCCQ_MAX_UV;
@@ -177,8 +179,12 @@ static int ufshcd_parse_regulator_info(struct ufs_hba =
*hba)
                goto out;
=20
        err =3D ufshcd_populate_vreg(dev, "vcc", &info->vcc);
-       if (err)
-               goto out;
+       if (err) {
+               err =3D ufshcd_populate_vreg(dev, "vcc-voltage-level",
+                                          &info->vcc);
+               if (err)
+                       goto out;
+       }
=20
        err =3D ufshcd_populate_vreg(dev, "vccq", &info->vccq);
        if (err)