Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Sep 2020 09:44:02 +0200
From:   Jiri Pirko <jiri@resnulli.us>
To:     Ido Schimmel <idosch@idosch.org>
Cc:     Moshe Shemesh <moshe@mellanox.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jiri Pirko <jiri@mellanox.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next RFC v4 04/15] devlink: Add reload actions stats
 to dev get
Message-ID: <20200915074402.GM2236@nanopsycho.orion>
References: <1600063682-17313-1-git-send-email-moshe@mellanox.com>
 <1600063682-17313-5-git-send-email-moshe@mellanox.com>
 <20200914134500.GH2236@nanopsycho.orion>
 <20200915064519.GA5390@shredder>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200915064519.GA5390@shredder>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Tue, Sep 15, 2020 at 08:45:19AM CEST, idosch@idosch.org wrote:
>On Mon, Sep 14, 2020 at 03:45:00PM +0200, Jiri Pirko wrote:
>> Mon, Sep 14, 2020 at 08:07:51AM CEST, moshe@mellanox.com wrote:
>> >Expose devlink reload actions stats to the user through devlink dev
>> >get command.
>> >
>> >Examples:
>> >$ devlink dev show
>> >pci/0000:82:00.0:
>> >  reload_action_stats:
>> >    driver_reinit 2
>> >    fw_activate 1
>> >    driver_reinit_no_reset 0
>> >    fw_activate_no_reset 0
>> >pci/0000:82:00.1:
>> >  reload_action_stats:
>> >    driver_reinit 1
>> >    fw_activate 1
>> >    driver_reinit_no_reset 0
>> >    fw_activate_no_reset 0
>> 
>> I would rather have something like:
>>    stats:
>>      reload_action:
>>        driver_reinit 1
>>        fw_activate 1
>>        driver_reinit_no_reset 0
>>        fw_activate_no_reset 0
>> 
>> Then we can easily extend and add other stats in the tree.
>> 
>> 
>> Also, I wonder if these stats could be somehow merged with Ido's metrics
>> work:
>> https://github.com/idosch/linux/commits/submit/devlink_metric_rfc_v1
>> 
>> Ido, would it make sense?
>
>I guess. My original idea for devlink-metric was to expose
>design-specific metrics to user space where the entity registering the
>metrics is the device driver. In this case the entity would be devlink
>itself and it would be auto-registered for each device.

Yeah, the usecase is different, but it is still stats, right.


>
>> 
>> 
>> >
>> >$ devlink dev show -jp
>> >{
>> >    "dev": {
>> >        "pci/0000:82:00.0": {
>> >            "reload_action_stats": [ {
>> >                    "driver_reinit": 2
>> >                },{
>> >                    "fw_activate": 1
>> >                },{
>> >                    "driver_reinit_no_reset": 0
>> >                },{
>> >                    "fw_activate_no_reset": 0
>> >                } ]
>> >        },
>> >        "pci/0000:82:00.1": {
>> >            "reload_action_stats": [ {
>> >                    "driver_reinit": 1
>> >                },{
>> >                    "fw_activate": 1
>> >                },{
>> >                    "driver_reinit_no_reset": 0
>> >                },{
>> >                    "fw_activate_no_reset": 0
>> >                } ]
>> >        }
>> >    }
>> >}
>> >
>> 
>> [..]