Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200915061110.25833-1-wenbin.mei@mediatek.com> <20200915061110.25833-2-wenbin.mei@mediatek.com>
In-Reply-To: <20200915061110.25833-2-wenbin.mei@mediatek.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Tue, 15 Sep 2020 10:28:15 +0200
Message-ID: <CAPDyKFpYAmhZXin7Lms9ymc2aXNY9UKyxYvW5PPZUqET2jBZOg@mail.gmail.com>
Subject: Re: [RESEND 1/3] mmc: dt-bindings: add support for MT8192 SoC
To:     Wenbin Mei <wenbin.mei@mediatek.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Chaotian Jing <chaotian.jing@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        DTML <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        srv_heupstream <srv_heupstream@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 15 Sep 2020 at 08:13, Wenbin Mei <wenbin.mei@mediatek.com> wrote:
>
> MT8192 mmc host ip is compatible with MT8183.
> Add support for this.
>
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>

Before we continue to extend the current DT bindings, can you please
convert from the legacy text based format to the yaml format. Then,
please add the new properties for MT8183 on top.

Kind regards
Uffe

> ---
>  Documentation/devicetree/bindings/mmc/mtk-sd.txt | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> index 26a8f320a156..6422ad7d439d 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> @@ -10,7 +10,7 @@ Required properties:
>  - compatible: value should be either of the following.
>         "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
>         "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
> -       "mediatek,mt8183-mmc": for mmc host ip compatible with mt8183
> +       "mediatek,mt8192-mmc", "mediatek,mt8183-mmc": for mmc host ip compatible with mt8183
>         "mediatek,mt8516-mmc": for mmc host ip compatible with mt8516
>         "mediatek,mt6779-mmc": for mmc host ip compatible with mt6779
>         "mediatek,mt2701-mmc": for mmc host ip compatible with mt2701
> @@ -27,6 +27,10 @@ Required properties:
>         "hclk" - HCLK which used for host (required)
>         "source_cg" - independent source clock gate (required for MT2712)
>         "bus_clk" - bus clock used for internal register access (required for MT2712 MSDC0/3)
> +       "sys_cg" - msdc subsys clock gate (required for MT8192)
> +       "pclk_cg" - peripheral bus clock gate (required for MT8192)
> +       "axi_cg" - AXI bus clock gate (required for MT8192)
> +       "ahb_cg" - AHB bus clock gate (required for MT8192)
>  - pinctrl-names: should be "default", "state_uhs"
>  - pinctrl-0: should contain default/high speed pin ctrl
>  - pinctrl-1: should contain uhs mode pin ctrl
> --
> 2.18.0