Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: W4dS+NKoczb/uFgiJQpnct2/tpr4/ydR+fpvqKV8jvXK+2Ymmmlop6w95BVSPPCYnvtCdFNVgV
 wpgd9ezuttGbJq4JiPjhqyazOAwlLNuqr0EHSa5oo0hFspVP1oUT6FNCQ9bqJLzTrLRrVJoamB
 hMTrqWVme0yr0QLJFxnRSgL4x//S0Z/h9KEkt5euUDbx5++Xiv8QD4r2bBMCAB5HeFiyoKEzhf
 7M+V4nlnW1xe7zB3GU1ewFvBP8lu0NbDux7ZkrGI9GUYuzfDPO2HLDt2iy+X6HqjMYwI7jaBsJ
 z7k=
Date:   Tue, 15 Sep 2020 08:51:37 +0000
From:   Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     <davem@davemloft.net>, <roopa@nvidia.com>, <nikolay@nvidia.com>,
        <jiri@mellanox.com>, <idosch@mellanox.com>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <bridge@lists.linux-foundation.org>,
        <UNGLinuxDriver@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.
Message-ID: <20200915085137.c7xfmk5bpjzniclp@soft-test08>
References: <20200904091527.669109-1-henrik.bjoernlund@microchip.com>
 <20200904091527.669109-5-henrik.bjoernlund@microchip.com>
 <20200904080257.6b2a643f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20200904080257.6b2a643f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for the review. Comments below.

The 09/04/2020 08:02, Jakub Kicinski wrote:
> 
> On Fri, 4 Sep 2020 09:15:24 +0000 Henrik Bjoernlund wrote:
> > +     rcu_read_lock();
> > +     b_port = rcu_dereference(mep->b_port);
> > +     if (!b_port)
> > +             return NULL;
> > +     skb = dev_alloc_skb(CFM_CCM_MAX_FRAME_LENGTH);
> > +     if (!skb)
> > +             return NULL;
> 
> net/bridge/br_cfm.c:171:23: warning: context imbalance in 'ccm_frame_build' - different lock contexts for basic block

I will assure that rcu_read_unlock() is called before any return.

-- 
/Henrik