Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2786961pxk; Tue, 15 Sep 2020 02:16:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcs3ziQtIrfsCmNjUPrJYp9ZWuUGpVroGn6FNvu4WkViNPUlF6SSQczPi2e1r+wZvFCNpO X-Received: by 2002:a17:906:118d:: with SMTP id n13mr18594013eja.162.1600161370177; Tue, 15 Sep 2020 02:16:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600161370; cv=none; d=google.com; s=arc-20160816; b=QsQPYxyDyLtO+Cd4nuN744uuYOvJbNlxzKCAkfzM2+RqNzbS341DxpqyvJ/zEd5STe ouZR9/x5nUfV3xypC0Otb1XAKiYOIB+f9464FPzC5rCeAtwOg1V/cAwPSB6YI3ZBTCm2 i187FVU1YkXcpdYjuvp56S7IZzhOQW6A4ZHy95+EnxTQultj+dQ8CycnrPT1Ettfp05E 43SJO32e0S5NF0/h5+tHohjVHPHcdTG6mlbs7G5cMG6oU0A89khqM83DX3oCvxcXAkoh GxKH6+MDsbDpxno4jynyMwD8J287cxpu0EhLtXINiC6qzj8hAHkKHPsqJpYCqxMx558n 79ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=FvaJmj45+hZz+9GgbNE3rwJ+H3JIoq7yGSJBBmV2IRo=; b=n0tnfFFAePZADvAsIFzeN2Q05u8WpYIMrGJU9eSnIY37EgUbjIsgVqfGjh9/mler7Q PgvfkCmkM1q1JJqJrHNQpdjiVi9OPWq6WrrwN2OrU62kcrwxXTmDVHyTAyPWfI2Ey5b4 tzOCk2h62oo611s2/kPy2nc4MvIJaYLEEQ8oCpXx0hAZFV2V/eVmCWJQx2YVW85k5ZZb 5pXYsObNOcoBq+rHrmk+bZEX2ley+yh6RjLwyspsiQsjIGEYafIkYG01pX7cyMN7VDKx +pqsdZfG1xkyF6Wmw8TJ+lNiaU+v+AHUk8K05AlMx5VRorCUijaHu5WF2/y5f6UxjbeS OfZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=GkbqEKal; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x10si8650094eju.11.2020.09.15.02.15.47; Tue, 15 Sep 2020 02:16:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=GkbqEKal; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726378AbgIOJPO (ORCPT + 99 others); Tue, 15 Sep 2020 05:15:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726208AbgIOJPF (ORCPT ); Tue, 15 Sep 2020 05:15:05 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CEA3C06174A; Tue, 15 Sep 2020 02:15:05 -0700 (PDT) Received: from zn.tnic (p200300ec2f0e42006449c187a2f3906a.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:4200:6449:c187:a2f3:906a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E63A61EC058B; Tue, 15 Sep 2020 11:15:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1600161304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=FvaJmj45+hZz+9GgbNE3rwJ+H3JIoq7yGSJBBmV2IRo=; b=GkbqEKalSpf/Xzq/JASeaeWNQEP/8z0+XBeu/z41zpb/oajBRyQPsnmV9nPp5Cn3y/yHiq 1wgTdXQD4bg9PC43lr17FKwI/WIpxk9jAXzkVJfgBCSaFflk0j7N85rv56YGokZtzHW34f Ol0BJNYiqpqVNIoiJogIv5ktGPF7RGk= Date: Tue, 15 Sep 2020 11:15:02 +0200 From: Borislav Petkov To: Maxim Levitsky Cc: Alex Dewar , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] SVM: nSVM: fix resource leak on error path Message-ID: <20200915091502.GE14436@zn.tnic> References: <20200914194557.10158-1-alex.dewar90@gmail.com> <922e825c090892f22d40a469fef229d62f40af5e.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <922e825c090892f22d40a469fef229d62f40af5e.camel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 12:07:25PM +0300, Maxim Levitsky wrote: > I think that this patch is based on unmerged patch, since I don't see > any memory allocation in nested_svm_vmrun_msrpm, nor out_free label. > in nether kvm/master, kvm/queue nor in upstream/master Paolo and I need to figure out first how to share the SEV-ES enablement work and the other patches touching that file and then pile more fixes ontop. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette