Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2798541pxk; Tue, 15 Sep 2020 02:38:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRdCDu/LVABR7TbkuJQ+Dmq/6p27YzrATyB+UTTMZ9fWEzc/HOUgvVwE26k398vBFri26X X-Received: by 2002:a05:6402:6c9:: with SMTP id n9mr21431630edy.297.1600162703928; Tue, 15 Sep 2020 02:38:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600162703; cv=none; d=google.com; s=arc-20160816; b=tEkMk1J9MsJiNLals0jcpTNfW+suv3GcUj08gA+p2VyWkIBONg+S1cAY6Fq272w71U 33QKO2cvJ0WkQMbNe6J3/BnXOhl8bSG72KEPV0pGrPNEcBAD6GwL0PIrcVOeu+43Lf1f r+W85CcAmTSXKpZTbaM8YdbVzlB2vcnEj9+lXMqZHCDjAM7JFYIBMuDyLzXokextc/J7 RmlGb5tXHfD0nMxYi/qOcXLgk/9qNBKNy8PNValHmJuFdu51ch5APMVTVDdrEbZSy0mF ZIc8bN744/ARB34wRXagRfyQ+giE4TtXXY6Zq4xacSCh6HCAFODli5FqPeTR0ylWt5ny uMwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=v+BbwSNEJ4DkTteOvHGS5HwZg8drdSNxmJf6M4BBwPA=; b=fLrnUHma2rJtKwZGR0uExvllhKcEd2uYGvMyfQvsXUqQMrs5f5NkXRxvMQKAE0kiRl BEcV6Z0Vt113TFROFFQDU4pERjM5/aa9ub4R2at1YAETpYXzXNILum7XspMNNPvugNeA BxhjMiZKQA/3FZ6igdVl+whV50hLafRLFKyJtWqlOtR1V/Sx2Co/vOUP35BJ6xQUFYv1 afZIETElWqI8pe5UnrgIFg31M0B5t6AC+RT/+S+zukHlAu6mLM2ln/P3eVSu0qf1rHk7 ByU0Sxkdls8SkmeuToP0REvi5b0ydjROzUxig4QmzM8qTd6Msw8LxqFWZK+GaiWhPQXo 79yA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bt10si9247914edb.554.2020.09.15.02.38.00; Tue, 15 Sep 2020 02:38:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726418AbgIOJgD (ORCPT + 99 others); Tue, 15 Sep 2020 05:36:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbgIOJgA (ORCPT ); Tue, 15 Sep 2020 05:36:00 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B4A3C06174A for ; Tue, 15 Sep 2020 02:35:59 -0700 (PDT) Received: from ramsan ([84.195.186.194]) by xavier.telenet-ops.be with bizsmtp id U9bt230034C55Sk019btuN; Tue, 15 Sep 2020 11:35:55 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1kI7NQ-00060F-Vq; Tue, 15 Sep 2020 11:35:52 +0200 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1kI7NQ-0007eP-T2; Tue, 15 Sep 2020 11:35:52 +0200 From: Geert Uytterhoeven To: Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S . Miller" , Jakub Kicinski , Arnd Bergmann Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] chelsio/chtls: Re-add dependencies on CHELSIO_T4 to fix modular CHELSIO_T4 Date: Tue, 15 Sep 2020 11:35:51 +0200 Message-Id: <20200915093551.29368-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As CHELSIO_INLINE_CRYPTO is bool, and CHELSIO_T4 is tristate, the dependency of CHELSIO_INLINE_CRYPTO on CHELSIO_T4 is not sufficient to protect CRYPTO_DEV_CHELSIO_TLS and CHELSIO_IPSEC_INLINE. The latter two are also tristate, hence if CHELSIO_T4=n, they cannot be builtin, as that would lead to link failures like: drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c:259: undefined reference to `cxgb4_port_viid' and drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:752: undefined reference to `cxgb4_reclaim_completed_tx' Fix this by re-adding dependencies on CHELSIO_T4 to tristate symbols. The dependency of CHELSIO_INLINE_CRYPTO on CHELSIO_T4 is kept to avoid asking the user. Fixes: 6bd860ac1c2a0ec2 ("chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4") Reported-by: kernel test robot Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/chelsio/inline_crypto/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/chelsio/inline_crypto/Kconfig b/drivers/net/ethernet/chelsio/inline_crypto/Kconfig index 1923e713b53a1bf5..7dfa57348d542921 100644 --- a/drivers/net/ethernet/chelsio/inline_crypto/Kconfig +++ b/drivers/net/ethernet/chelsio/inline_crypto/Kconfig @@ -15,6 +15,7 @@ if CHELSIO_INLINE_CRYPTO config CRYPTO_DEV_CHELSIO_TLS tristate "Chelsio Crypto Inline TLS Driver" + depends on CHELSIO_T4 depends on TLS_TOE help Support Chelsio Inline TLS with Chelsio crypto accelerator. @@ -25,6 +26,7 @@ config CRYPTO_DEV_CHELSIO_TLS config CHELSIO_IPSEC_INLINE tristate "Chelsio IPSec XFRM Tx crypto offload" + depends on CHELSIO_T4 depends on XFRM_OFFLOAD depends on INET_ESP_OFFLOAD || INET6_ESP_OFFLOAD help -- 2.17.1