Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 15 Sep 2020 12:28:17 +0200
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Biwen Li <biwen.li@oss.nxp.com>
Cc:     leoyang.li@nxp.com, linux-rtc@vger.kernel.org,
        linux-kernel@vger.kernel.org, jiafei.pan@nxp.com,
        Biwen Li <biwen.li@nxp.com>
Subject: Re: rtc: fsl-ftm-alarm: add shutdown interface
Message-ID: <20200915102817.GL4230@piout.net>
References: <20200330122616.24044-1-biwen.li@oss.nxp.com>
 <20200330164400.GE846876@piout.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200330164400.GE846876@piout.net>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 30/03/2020 18:44:01+0200, Alexandre Belloni wrote:
> On 30/03/2020 20:26:16+0800, Biwen Li wrote:
> > From: Biwen Li <biwen.li@nxp.com>
> > 
> > Add shutdown interface
> > 
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > ---
> >  drivers/rtc/rtc-fsl-ftm-alarm.c | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
> > index d7fa6c16f47b..118a775e8316 100644
> > --- a/drivers/rtc/rtc-fsl-ftm-alarm.c
> > +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
> > @@ -307,6 +307,15 @@ static int ftm_rtc_probe(struct platform_device *pdev)
> >  	return 0;
> >  }
> >  
> > +static void ftm_rtc_shutdown(struct platform_device *pdev)
> > +{
> > +	struct ftm_rtc *rtc = platform_get_drvdata(pdev);
> > +
> > +	ftm_irq_acknowledge(rtc);
> > +	ftm_irq_disable(rtc);
> > +	ftm_clean_alarm(rtc);
> 
> If the alarm is able to start the platform, then you probably don't want
> to disable the alarm on shutdown.
> 

I realise you never replied to that question. Is that patch still of
interest?

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com