Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Biwen Li <biwen.li@nxp.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "Biwen Li (OSS)" <biwen.li@oss.nxp.com>
CC:     Leo Li <leoyang.li@nxp.com>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jiafei Pan <jiafei.pan@nxp.com>
Subject: RE: [EXT] Re: rtc: fsl-ftm-alarm: add shutdown interface
Thread-Topic: [EXT] Re: rtc: fsl-ftm-alarm: add shutdown interface
Thread-Index: AQHWBo7q7oogBWYJ/0Ch/nk6xakViKhhV7UAgQkxBoCAAAFUcA==
Date:   Tue, 15 Sep 2020 10:35:12 +0000
Message-ID: <DB6PR0401MB24385907880BAA626E5909528F200@DB6PR0401MB2438.eurprd04.prod.outlook.com>
References: <20200330122616.24044-1-biwen.li@oss.nxp.com>
 <20200330164400.GE846876@piout.net> <20200915102817.GL4230@piout.net>
In-Reply-To: <20200915102817.GL4230@piout.net>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 168cd5df-874f-4afc-a9da-08d8596306d8
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2020 10:35:12.3092
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xplV1hBWvij1QQ4ppFPxSz9e2AWTVzRHMp1F/sTn3w7s4W7K9EhEEkEA1ClW/HkPr4IlCkRSdGSmxzC7TWaTpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5292
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Hi,
>=20
> On 30/03/2020 18:44:01+0200, Alexandre Belloni wrote:
> > On 30/03/2020 20:26:16+0800, Biwen Li wrote:
> > > From: Biwen Li <biwen.li@nxp.com>
> > >
> > > Add shutdown interface
> > >
> > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > > ---
> > >  drivers/rtc/rtc-fsl-ftm-alarm.c | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > >
> > > diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > b/drivers/rtc/rtc-fsl-ftm-alarm.c index d7fa6c16f47b..118a775e8316
> > > 100644
> > > --- a/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
> > > @@ -307,6 +307,15 @@ static int ftm_rtc_probe(struct platform_device
> *pdev)
> > >     return 0;
> > >  }
> > >
> > > +static void ftm_rtc_shutdown(struct platform_device *pdev) {
> > > +   struct ftm_rtc *rtc =3D platform_get_drvdata(pdev);
> > > +
> > > +   ftm_irq_acknowledge(rtc);
> > > +   ftm_irq_disable(rtc);
> > > +   ftm_clean_alarm(rtc);
> >
> > If the alarm is able to start the platform, then you probably don't
> > want to disable the alarm on shutdown.
> >
>=20
> I realise you never replied to that question. Is that patch still of inte=
rest?
Hi Alex, you can drop it. Thanks.
Best Regards,
Biwen Li
>=20
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbootl=
in.c
> om%2F&amp;data=3D02%7C01%7Cbiwen.li%40nxp.com%7Cd688030894714bca7
> 5c708d8596210ec%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 7357625013809281&amp;sdata=3DpOBMmsxi7DVlywuLZ2LOLVgK4r4GtvW1PYq1
> p9JVv74%3D&amp;reserved=3D0