Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200915150202.24165-1-qiangqing.zhang@nxp.com>
 <CAHp75Vftg3GmBsCCrZeXo4eofOYTJ2ii+s64hY5FqZadvX6Bww@mail.gmail.com> <DB8PR04MB6795840F4C0D938A14D1E3BEE6200@DB8PR04MB6795.eurprd04.prod.outlook.com>
In-Reply-To: <DB8PR04MB6795840F4C0D938A14D1E3BEE6200@DB8PR04MB6795.eurprd04.prod.outlook.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 15 Sep 2020 13:42:23 +0300
Message-ID: <CAHp75Vdq2atO9MP8=cgHW9Rn8rSf+GdtmRThAXFB9LB-Ym95xg@mail.gmail.com>
Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle system
To:     Joakim Zhang <qiangqing.zhang@nxp.com>
Cc:     "sean@mess.org" <sean@mess.org>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Sep 15, 2020 at 11:06 AM Joakim Zhang <qiangqing.zhang@nxp.com> wro=
te:
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: 2020=E5=B9=B49=E6=9C=8815=E6=97=A5 15:18
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: sean@mess.org; mchehab@kernel.org; linux-media@vger.kernel.org; linux=
-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] media: rc: gpio-ir-recv: add QoS support for cpuidle=
 system
> On Tuesday, September 15, 2020, Joakim Zhang <qiangqing.zhang@nxp.com> wr=
ote:


> +       ret =3D pm_runtime_get(dev);
> +       if (ret < 0)
>
>
>
> Here is reference counter leak.
>
>
>
> Thanks Andy for your kindly review.
>
> pm_runtime_get increase the usage_count even it fails, so need call pm_ru=
ntime_put_noidle here to balance the usage_count. Am I right?

Yes.

> +               return IRQ_NONE;


--=20
With Best Regards,
Andy Shevchenko