Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2865664pxk; Tue, 15 Sep 2020 04:34:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPzS6QBwViDtu/YWAVMc75c1a4o2mlqPk8OR7Bh4aVBCzq2j0EOPJzQ2z1BkcCG2w/O/VD X-Received: by 2002:a50:a693:: with SMTP id e19mr21390770edc.205.1600169668434; Tue, 15 Sep 2020 04:34:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600169668; cv=none; d=google.com; s=arc-20160816; b=YC486yP2r5A9vrecLfaWPiJjP/PZD88MbvWnbEIcyf66zPQzhxgNoRfmFL+tH6e3Qf j61elqQlD/ehHfOAV7CvXN+tk5dIaiKdv8Su5oGGpBlwtW+zXiQjNC+EWCiXglCB8uiE KWrao1HptHtz08MP4LoofmcMGvVO+nnS9U4aVuDJw5hjY9414Vw9fl4X0S/mwezUXyZT 0YMOXx6zxq0xq1Eue899BsgnBTM9IRvhHyCagNVebMeSG+7WFYyuAcsMqpe0XNOxksf+ 3IAkzcUhDoRB0wWPrT0YPgOuNSEeJiEnI+BS7R8BEU2eT/yKNT5U2awA+g2+YHjiLA5m uwpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=FijsbipQD3LwO5461ADaOwAqluTpZVpP8QOgC5qWGW8=; b=gw+JJSj7A+TBSXwZEUzkXYnIUlGn0VMuG0g9dGIKN4WqdQbgfhAKlqwAOjGzQPOSjD M4GhYkPQhN12Pu/0kKorKkaaddrs2wMzCIuMDPyLMc6PYBn6B17S0G5cyg3AudKkiTdw o+GzVbv2XhotNEPw1n31IlNPP2Ed5qmCecxJFByd1nFa8Kj6bpadZwvraXJ+ni5OUfw1 hrBe4OQytaMCO7UA1A0JWrbz/RuJWfCL6llu10EIzj/VGV1cEL4gFICt+zdUnpxQrWuv Rp1lsz/f+P1fb+DBGgRYWpVZz11kBl/LObd/MEMyUNhsFKs4IWzLPR37qapRRE5mgJzA Y4Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=EqW4ku7Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p23si7102264eju.83.2020.09.15.04.34.05; Tue, 15 Sep 2020 04:34:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=EqW4ku7Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726357AbgIOLcf (ORCPT + 99 others); Tue, 15 Sep 2020 07:32:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726135AbgIOL10 (ORCPT ); Tue, 15 Sep 2020 07:27:26 -0400 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB6EAC06174A; Tue, 15 Sep 2020 04:26:39 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4BrLXQ46X3z9sTN; Tue, 15 Sep 2020 21:26:30 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1600169192; bh=4esK02AyElAnyDXkxcmOZ58SrlxD5sLeYfaYLnFksAA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=EqW4ku7Y8V1CrYGyOReTmatCQO246pQi3XD9hK8QImXa+8kAvrroYZZVLIhB5Cv/L 1HEJZtQS+acKXCy5mMNetAonLI2gIKpEbZxxPKtbRyxAhp7DbXfXGjBEQew0/9IUzn uRXbt4CCQ1FGVyJHUik+SPO4pM7Ori2zZ2q8Sd+rd7hSHtcrPmjcbc39dwb8ouGs30 Ogk0REO3vpcreFt7pS/TdkFGqXscY4gN+KJ+bOxq48bkRgo6e0daxPDJKsbboli0bK vt48IMrpUsOzMpDaqIlp3QryBj7HBTRa4U3hJ9O+w+fwBRbfp40WWPlE48hxMPs7KN n614Pr2VN9Jeg== From: Michael Ellerman To: Nicholas Piggin , peterz@infradead.org Cc: Jens Axboe , linux-arch@vger.kernel.org, "linux-mm \@ kvack . org" , "Aneesh Kumar K . V" , linux-kernel@vger.kernel.org, Andy Lutomirski , Dave Hansen , sparclinux@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" Subject: Re: [PATCH v2 1/4] mm: fix exec activate_mm vs TLB shootdown and lazy tlb switching race In-Reply-To: <1600137586.nypnz3sbcl.astroid@bobo.none> References: <20200914045219.3736466-1-npiggin@gmail.com> <20200914045219.3736466-2-npiggin@gmail.com> <20200914105617.GP1362448@hirez.programming.kicks-ass.net> <1600137586.nypnz3sbcl.astroid@bobo.none> Date: Tue, 15 Sep 2020 21:26:29 +1000 Message-ID: <87lfhbp9ga.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nicholas Piggin writes: > Excerpts from peterz@infradead.org's message of September 14, 2020 8:56 pm: >> On Mon, Sep 14, 2020 at 02:52:16PM +1000, Nicholas Piggin wrote: >>> Reading and modifying current->mm and current->active_mm and switching >>> mm should be done with irqs off, to prevent races seeing an intermediate >>> state. ... >>> >>> Signed-off-by: Nicholas Piggin >> >> Acked-by: Peter Zijlstra (Intel) >> >> I'm thinking we want this selected on x86 as well. Andy? > > Thanks for the ack. The plan was to take it through the powerpc tree, > but if you'd want x86 to select it, maybe a topic branch? Although > Michael will be away during the next merge window so I don't want to > get too fancy. Would you mind doing it in a follow up merge after > powerpc, being that it's (I think) a small change? Or get akpm to take the series, including the x86 change. cheers