Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2995253pxk; Tue, 15 Sep 2020 07:36:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIM52+h/gUY8bdHTEryCChCvcU6xOLIQVJe/1jrf1cTd3/Z3hgxlEjTpXsCtb6Q7Kas2X6 X-Received: by 2002:a05:6402:1819:: with SMTP id g25mr21979697edy.292.1600180609501; Tue, 15 Sep 2020 07:36:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600180609; cv=none; d=google.com; s=arc-20160816; b=m5Gt4aht+i1KI/+B4eiprKZ11tscP2OC8JSVeCSvekZn+HvSH93l5CsnxdR5+FxSIn znPMkNPepKYenb1mdeORetwPzdXZ0KUa3BrZR1mYpt9HJ6vJ4k8ycvuprh5ju7qs3/VJ U7arHVEAYKKNw4j9/1zw6ZgZdmgyGEWyEfL+93ab739EHe+F/M9wzZEotvAg/L+nHwS4 uCTs+WUBi+u66Fu7MjrQuSkEY1nDDDBVk4Y4DTu33Dbv/qKDFR/6IhBmCvA7jW9suvur 3PGbAK1v5mpjChGkl4mFoZrqMKhult400HBONjs2ld5bSu6nI/vnLL6l9nf2Vr8W+XjU SXxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=14anG50Aa3WOKCmtLyBz8A0CHugiplkST/cPboXKO20=; b=Spttv/sZgVz7T4r1twr88Nb7xwE52DSy8vbrGcNZUQfBv+JFNjYBe0zN901AifZK3z MN3s/TjdMlNwTzEXnoxrC/C1tVyAGA9nhdlgmH2zO3RNVOSLtSMKyxCI6vkbNQElS6+2 tRFU2JtLokT+VKeXWFo7BQHx+gb9OWtPsyCLe16kFr6DmqQpnCj9Ny9bRFm6Gc1UyE0E 4rgiNM1/ZOX0jD6fPD3f4pqC3TTgnVwgrWQGEVpWz3o4SsshdtKYTTGqY83BgPYm9jqB 5hNXdnEmEQtQBbef4cP+HpyN3riFqZaKVcNGBosqHyVuhjT8dVkaLdK6xLCwDcG8Wsus m2Tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ppO4PXPU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id zl3si10038079ejb.374.2020.09.15.07.36.26; Tue, 15 Sep 2020 07:36:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ppO4PXPU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727151AbgIOOfa (ORCPT + 99 others); Tue, 15 Sep 2020 10:35:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726902AbgIOO1c (ORCPT ); Tue, 15 Sep 2020 10:27:32 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46E46C061788; Tue, 15 Sep 2020 07:25:58 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id a22so2976974ljp.13; Tue, 15 Sep 2020 07:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=14anG50Aa3WOKCmtLyBz8A0CHugiplkST/cPboXKO20=; b=ppO4PXPU2DK3J8X3ntQTbX2pO+BRWkBQ0sY9sUuSo4UknnFzoc9Iuhf1QvxmWFwPIm bL+uU6qEaM9TPGpnSL/GY1u1NkQMzmwtkmQJTOvEtACvkrs8uxexm8YKUZj8iXoD3yd+ PRFVeoNiiSEPP7B0csc2yYmrRohSGUkoVs8bB1zry3HhZvY8ic6znknNGZHlx1tOmL1j SqVLqC/v2LtmCS8CNACBlS8hzGe3ltJC3tS+wpna73nJh6a9gZb4s2EZT60luYemPsGB agXR7zVBY8LlNbBFuCKcXqa+3uX6OrgimFzg0tflxFbMWitX65PGetcLf0+H0rGwYmJe r6qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=14anG50Aa3WOKCmtLyBz8A0CHugiplkST/cPboXKO20=; b=Sva+x8u+ceKV7lizqg/82oK7InkwlvOSb5wapu00GBnE1HPS6VbRMaYKX7Ou3/3Gu5 G3UTsAE2H1oyUDFyBNEX59NjdPOyQC/ZoYdzLFvnFmokxJOwg9WrQ0g5/kmTaiMA++O5 pjI2Y9TiVV8uEC29Pcz/Mf39o7VMJGynyybFQ4/DoXPUn7unzAVkcWUZ17vP5mnb3Dlv Lbjpk/CEW8XWkeLVYdon+IVDVs6rWeUYKqAjSWIfY6ekVN3Hcu5tjt9kzaSgseM6qRmE m5Pa/fYsv2BSzbLXQDRISkV4o0GO2cYvEzlWn1LPzYqgZ5bMpXJj/ik9tKWM7e6OzRwJ uQqA== X-Gm-Message-State: AOAM530K3ndp/4wiyTYglq/IDInotBLC6rRlNnwpvP1WKvzfDiKKbhB0 OpR8E8Mwc2lt7G9ucOcssbFQYKE6+mkwb5rUHHM= X-Received: by 2002:a2e:95c5:: with SMTP id y5mr7660302ljh.44.1600179956643; Tue, 15 Sep 2020 07:25:56 -0700 (PDT) MIME-Version: 1.0 References: <20200915140159.23184-1-yuehaibing@huawei.com> In-Reply-To: <20200915140159.23184-1-yuehaibing@huawei.com> From: Fabio Estevam Date: Tue, 15 Sep 2020 11:25:45 -0300 Message-ID: Subject: Re: [PATCH 3/3] clk: imx31: Make mx31_clocks_init static To: YueHaibing Cc: Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Sascha Hauer , NXP Linux Team , linux-clk , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 11:02 AM YueHaibing wrote: > > Fix sparse warning: > > drivers/clk/imx/clk-imx31.c:135:12: warning: > symbol 'mx31_clocks_init' was not declared. Should it be static? Same as the other comment for mx35, This function should be removed. I will send a patch removing it.