Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/4] kselftests/arm64: add PAuth test for whether exec()
 changes keys
To:     Dave Martin <Dave.Martin@arm.com>,
        Boyan Karatotev <boyan.karatotev@arm.com>
Cc:     Shuah Khan <shuah@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        amit.kachhap@arm.com, vincenzo.frascino@arm.com,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org
References: <20200828131606.7946-1-boyan.karatotev@arm.com>
 <20200828131606.7946-4-boyan.karatotev@arm.com>
 <20200902170052.GJ6642@arm.com>
 <70e207ea-f7c2-2c9d-e868-3ba3b6451c6f@arm.com>
 <20200907102717.GM6642@arm.com>
From:   Boyan Karatotev <boian4o1@gmail.com>
Message-ID: <4f38a974-d5a0-87e6-3db3-647e3cc32c0e@gmail.com>
Date:   Tue, 15 Sep 2020 16:18:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200907102717.GM6642@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/09/2020 11:27 am, Dave Martin wrote:
> On Thu, Sep 03, 2020 at 11:20:25AM +0100, Boyan Karatotev wrote:
>> On 02/09/2020 18:00, Dave Martin wrote:
>>> On Fri, Aug 28, 2020 at 02:16:05PM +0100, Boyan Karatotev wrote:
>>>> +int exec_sign_all(struct signatures *signed_vals, size_t val)
>>>> +{
>>>
>>> Could popen(3) be used here?
>>>
>>> Fork-and-exec is notoriously fiddly, so it's preferable to use a library
>>> function to do it where applicable.I would love to, but the worker needs a bidirectional channel and popen
>> only gives a unidirectional stream.
> 
> Ah, fair point.
> 
> Would it help if you created an additional pipe before calling popen()?
> 
> May not be worth it, though.  For one thing, wiring that extra pipe to
> stdin or stdout in the child process would require some extra work...
Well, I probably could, but I doubt the result would be any better. I
agree that I'm not sure the effort is worth it and would rather keep it
the same.