Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3111723pxk; Tue, 15 Sep 2020 10:18:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNybmsrWni/iQ3CtIpQxRSt9BuxEr1Vh4w7GWrSGVyv7bZ4niR7usB8hJVKQMMm2kVSxJg X-Received: by 2002:a17:906:9491:: with SMTP id t17mr22008581ejx.253.1600190286234; Tue, 15 Sep 2020 10:18:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600190286; cv=none; d=google.com; s=arc-20160816; b=V05PEkAYHSaVj/Z63lcSFshkCn9O6MMuLSrkB9xkVbaAhoJiWgB8g1qBlETJLdVtFZ v7eCtHQnRfa/LByHAOyCHjnkY4t8ux3LzAM8hdrzXpCjAGpVLALnjv8ftJHfsGfZNaJ6 oekXSFBPJM/cptXiNnvqGeVc06+JzZcrEFv3cUGWJkI56zrTDTIAH9OR9q0Uf3vv0sIi y9P1nlDMMk4ncG+573p/1Y9NkjeVWXqMR/5V3R8gw6EQJH5vkZSrXIMvvvCcFxOpI0rH s4ZcnisqUYpeV23kfsjkS+cavj8TYrHgiKyc4Cmx3AY9Eqm4PKmO/q8iKVLJ0WGrRv9t u37w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=DaCYXmm4zAWGdlT9ud6DozIZ/XQXfuW/Ur5U1dOb6N8=; b=CVyjMcYlOIY3BiOVl8QWEPGYNC1K+BlfmQT5RRSThTXzaL/cxF382RuDErieqqipt2 VZ+KtrO0mb4N4hgvAqzX6VHEnhnuNhurGHjCt5d9r3d84mizI+mMKuSwYmthC20tOpVt NFuoE2+XE3n9fN+A/Jm6/VFbyedoEW13f64k6YZ/zDKsbvQ8Jj7jRyciFvbN0WKgA/3O hoYVDkp+axmrwTEptuDkfuFWH3FfFWwx7pOIFWWhvNJWl+T8VPdoAcGWo8lZwpvZpdfC CM0iZTsqPlYsj8sgY57m3qksqGtPZpbcpMyeyhsaKA384Rk1AsjW+3dykhqGIvd2wGoO XS4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pk27si9843829ejb.715.2020.09.15.10.17.42; Tue, 15 Sep 2020 10:18:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727822AbgIORHq (ORCPT + 99 others); Tue, 15 Sep 2020 13:07:46 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:49549 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727430AbgIOQWV (ORCPT ); Tue, 15 Sep 2020 12:22:21 -0400 Received: from ip5f5af089.dynamic.kabel-deutschland.de ([95.90.240.137] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kIDNS-0005wg-Oh; Tue, 15 Sep 2020 16:00:18 +0000 Date: Tue, 15 Sep 2020 18:00:18 +0200 From: Christian Brauner To: Kees Cook Cc: linux-kernel@vger.kernel.org, Thadeu Lima de Souza Cascardo , Max Filippov , Michael Ellerman , Christian Brauner , Andy Lutomirski , Will Drewry , linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 06/15] selftests/seccomp: mips: Remove O32-specific macro Message-ID: <20200915160018.fstuxjp5mkwieweq@wittgenstein> References: <20200912110820.597135-1-keescook@chromium.org> <20200912110820.597135-7-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200912110820.597135-7-keescook@chromium.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 12, 2020 at 04:08:11AM -0700, Kees Cook wrote: > Instead of having the mips O32 macro special-cased, pull the logic into > the SYSCALL_NUM() macro. Additionally include the ABI headers, since > these appear to have been missing, leaving __NR_O32_Linux undefined. > > Signed-off-by: Kees Cook > --- Looks good! Acked-by: Christian Brauner