Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200909130720.105234-1-zhengbin13@huawei.com> <1fce0f2a-3777-e6d8-5a09-30261f843cfd@amd.com>
In-Reply-To: <1fce0f2a-3777-e6d8-5a09-30261f843cfd@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 15 Sep 2020 15:16:32 -0400
Message-ID: <CADnq5_NoeFbBAMT6s_ictVXsUc2tx1U48MLxnMbAr2Sd58jyYA@mail.gmail.com>
Subject: Re: [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc:     Zheng Bin <zhengbin13@huawei.com>,
        "Deucher, Alexander" <alexander.deucher@amd.com>,
        Dave Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>, yi.zhang@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

I question the value of these warnings.  Why even have a boolean type
if you are going to get warnings when you use them...
That said, applied to avoid getting these patches again and again
every time someone sees this.

Alex

On Wed, Sep 9, 2020 at 9:21 AM Christian K=C3=B6nig <christian.koenig@amd.c=
om> wrote:
>
> Acked-by: Christian K=C3=B6nig <christian.koenig@amd.com> for the series.
>
> Am 09.09.20 um 15:07 schrieb Zheng Bin:
> > Zheng Bin (8):
> >    drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v9_0.c
> >    drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.=
c
> >    drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_0.=
c
> >    drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_2.=
c
> >    drm/amd/amdgpu: fix comparison pointer to bool warning in si.c
> >    drm/amd/amdgpu: fix comparison pointer to bool warning in uvd_v6_0.c
> >    drm/amd/amdgpu: fix comparison pointer to bool warning in
> >      amdgpu_atpx_handler.c
> >    drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v4_0.=
c
> >
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 4 ++--
> >   drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c           | 2 +-
> >   drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c            | 2 +-
> >   drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c           | 4 ++--
> >   drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c           | 2 +-
> >   drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c           | 2 +-
> >   drivers/gpu/drm/amd/amdgpu/si.c                  | 2 +-
> >   drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c            | 4 ++--
> >   8 files changed, 11 insertions(+), 11 deletions(-)
> >
> > --
> > 2.26.0.106.g9fadedd
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx