Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3192647pxk; Tue, 15 Sep 2020 12:31:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhhoHVTp8FP3YlVSHlH780eZBvHrl0itVIA+V8kpgn3hUl3S3rz9Wbcs+TTmQEDj8ryYn/ X-Received: by 2002:a17:906:4a8c:: with SMTP id x12mr22455639eju.271.1600198271171; Tue, 15 Sep 2020 12:31:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600198271; cv=none; d=google.com; s=arc-20160816; b=whZh/DR79pUn8+7NKpubfzgLjeHnH/NF9RM1ZcT+5aZNtvkgASva5v9QTmzWxvuCDp OWESBRshAjKtCo88JH1jNtSqr6VbMd4AKOz2bseT+QD6XdN+zk/I1buTE/3Gl8dn0bMT X8ofkKhblYQ8RPUKJIQgMKEjKCSnxVKmKSAL6rGnHE7evOoFcE8fKb1iZut4ffzB4Tk5 QXVjAt3ZHZdWoSKlOYwzYws/iAZy65ZpeUJnQraAEXoETocxUscajEGPRgfO8TjpWFGB Rpn0Ypvzybdt7e92c+MIHHWxSBaWRmTSgohIlfXINZhQnkAJ8yoV40LSqN/pmgwv/x+F oCJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=n+2lLM2k9R0KoxJS0Yj1YjWZ2tzOL4fA5WnRQ04/Q60=; b=swsvFJ0e1ISpiDd2z3i51+swtFlQDP2UPbbG4/Ejc3RNQUJgVhkXJiYxuyUwqiL+re w1lNQNo4UVaMSswMu0sK4aEp+i+/JW4RjJfETnOPZrNaMoKv+hCVM3AJ14f3R7OzQw6N BOBJ/GIPEeO1lX1+60jVV/aEDGBhzG0rOO5Qj7eDgnbHA935MldnFR5KWSWJlCoAsXjP fFijxplFCXnwEkWmU/bIHxZpXUiXiBv8LrcZiqkZbGwPGFHkJZ9XMcJJrOfngqZESdRh cbIzoBddK5C0qich6NOw/ieNtmbW0eZskxmOUokwoU0mNgE2ZPKmY8WoKbLlUJjmZDuz zWcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=brxUvCMw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ba30si10505663edb.44.2020.09.15.12.30.48; Tue, 15 Sep 2020 12:31:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=brxUvCMw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727888AbgIOT2d (ORCPT + 99 others); Tue, 15 Sep 2020 15:28:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43355 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727586AbgIOT1Q (ORCPT ); Tue, 15 Sep 2020 15:27:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600198032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n+2lLM2k9R0KoxJS0Yj1YjWZ2tzOL4fA5WnRQ04/Q60=; b=brxUvCMwYEyhDOLxG1vctoXChkUqUX32REEo6STwQjSDhBe0EY9CpEAZ6BL1PjPrHj4hv4 QDqnWOltKOC4TvBiqzFJY5SfQTBlxRqwidII6rcJE6urYsQnDAMFrI6VJK6AuVFREoKE8Q 4pc8a+hp4CIEHzI8iBGmi6+QQWJ6Cnk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-umcZtNTuM9mjJt5pxoM11g-1; Tue, 15 Sep 2020 15:27:10 -0400 X-MC-Unique: umcZtNTuM9mjJt5pxoM11g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9F7681074653; Tue, 15 Sep 2020 19:27:08 +0000 (UTC) Received: from treble (ovpn-112-136.rdu2.redhat.com [10.10.112.136]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0455761982; Tue, 15 Sep 2020 19:27:06 +0000 (UTC) Date: Tue, 15 Sep 2020 14:27:05 -0500 From: Josh Poimboeuf To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Uros Bizjak , Andi Kleen Subject: Re: [PATCH v2 1/2] KVM: VMX: Move IRQ invocation to assembly subroutine Message-ID: <20200915192705.vadb4he5obu3vdzm@treble> References: <20200915191505.10355-1-sean.j.christopherson@intel.com> <20200915191505.10355-2-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200915191505.10355-2-sean.j.christopherson@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 12:15:04PM -0700, Sean Christopherson wrote: > Move the asm blob that invokes the appropriate IRQ handler after VM-Exit > into a proper subroutine. Unconditionally create a stack frame in the > subroutine so that, as objtool sees things, the function has standard > stack behavior. The dynamic stack adjustment makes using unwind hints > problematic. > > Suggested-by: Josh Poimboeuf > Cc: Uros Bizjak > Signed-off-by: Sean Christopherson Acked-by: Josh Poimboeuf -- Josh