Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3207144pxk; Tue, 15 Sep 2020 12:57:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcnB85QRxIWsLIY7cJH/T0pPf+7YmVT89TTHBRNU+D4QyuaEza43+YlM7Amoy16t6ZoBCO X-Received: by 2002:aa7:dd0d:: with SMTP id i13mr24450484edv.314.1600199860319; Tue, 15 Sep 2020 12:57:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600199860; cv=none; d=google.com; s=arc-20160816; b=wDCnWuNC7/fCotOipuyPAsJMH7dFzJAHzptQwWSOQt3tpcYGw7vRVZ3keyWQNDBNV5 tAwL+CkXycHznyyxAKp26dZ/4UHxci/shZgwjH1VzSYOsv3YQiaN+iBafGop2sMgEdU5 gITSTj3zUnoMTEhq4fMa5IUNfD1VTVnPvH0Qhgb3vnQf8ZIeVLUmsh7R2z5ujl4cIqFS a7Qq4AZ3qn/aFS+Tma9b/Vo6ifVVuVKXVrIAhhZSshKzkX0i7DRXbyjFesxbOqfwbI0p uif1uGoiELCt0+Ou8DmELrTS+fE6SdJzdF8+1xhOURUm5CxhCPJlJhks4+Z7a/8dD2oF w4Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=h+Glag7Zdcx+JA5O5eROeVL4B8Ql3yXhj7TU2E4Q+gU=; b=vRRCN/pTVKUxCgVVb70JYEsjDqx6sL+IuSjsxveTwQxiq0zQ5XB1cLK4vsE9MQ+8l4 PuUPaJZPqBnfnLTq95pknm3I1xPSzmHEGiadURLYkhJnnhhHl5A9m8CIlCGFsdTu99IJ 3qd2cBf4RepexZBs0rZpOOKk5oepRNP0Suu83I9DoPx8A2YZTCoTc6kXRluGH2/dGC2R 4N1xQcmakpJUsh5K9bDTjJ0aM1B0YdNsqCU/DOWvavdDelLagioMHp4rfWknfuLw8wND +Y+IDBNWZyXlGUeSX738kRY6CUHa6oh8rBL6lu27Zvs11U9FjpQzZVtHT4Ylgz3/x3iu FMEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=mfMz05Wy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q5si9796482ejj.123.2020.09.15.12.57.16; Tue, 15 Sep 2020 12:57:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=mfMz05Wy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727816AbgIOTzB (ORCPT + 99 others); Tue, 15 Sep 2020 15:55:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727858AbgIOTxs (ORCPT ); Tue, 15 Sep 2020 15:53:48 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA73FC06174A; Tue, 15 Sep 2020 12:53:47 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id g4so4291564edk.0; Tue, 15 Sep 2020 12:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h+Glag7Zdcx+JA5O5eROeVL4B8Ql3yXhj7TU2E4Q+gU=; b=mfMz05Wy0Rzi3mc9FRF90iBbA+HVDHL4eISMtdCcvtfUvBQM8Wh5qiWEAI/6L8k0oh AhFsZPp4OUXp1F8ZdKXdwcQJsuHQ1Zy8naiBndsPu70ZwZQoQpvXgSd54Eyhu79W36Ho Pc/au1ytVTbm4f2LpU9Td2cdox15NHuXZSR/vJwUD2y/hrA1VD5Hppc4XvPlS5chwMqD lznko/lVoIDy4XNuCtmT1zWCCktBAUIBTQsjy+IgPmfQBFjEksf+EX2rVk5+KvSAQyb/ GGfRamqsqpooy6xQRI1jsubexprAnEoblMG0wLEzt/5+kbEQ+rUYebyqCA4rEZhMhpaF BgYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h+Glag7Zdcx+JA5O5eROeVL4B8Ql3yXhj7TU2E4Q+gU=; b=tRivKBzRGs1PMJv9mtwSdub4uIWm213gwgxg7TMAq+fOgMaRTmrbPWQYLZ66WoU/Oo r/2VzF4BQgAJGfzm8Y/hi6k3Nfw/k4mlNmg1TYQ69Ns+uUqSQBU3oVNG8qkz/c3pOhz/ IFsrOwyfma+rmjyJdonV8e66vqtICPlkI3vg4zBV9o0KuV80N541P9kCf2wksDU/Y42h OglYIigeZiSGRtApZUY4LT59XqcicJpyOYj3dYbI0q/0WOqlg/4jWwjTuhWqd7z0H7o5 sstwcm5fPQvYMIHU77hLiFOdwfza8XvqxBzAsUBxGIYpeps40V/fvg0KFYgqeb6RLUAz D7RA== X-Gm-Message-State: AOAM531D/q+ZdWFu+WheRR/xRICI8f2uRZLtY2gYL0/ifNUBTPiGHWpa UjU7zmpdOZ2VuS3g6h8+0b+o3MPW0UWsTtFF40k= X-Received: by 2002:a05:6402:489:: with SMTP id k9mr23671549edv.287.1600199626131; Tue, 15 Sep 2020 12:53:46 -0700 (PDT) MIME-Version: 1.0 References: <20200909160409.8678-1-narmstrong@baylibre.com> <20200909160409.8678-2-narmstrong@baylibre.com> In-Reply-To: <20200909160409.8678-2-narmstrong@baylibre.com> From: Martin Blumenstingl Date: Tue, 15 Sep 2020 21:53:35 +0200 Message-ID: Subject: Re: [PATCH 1/5] phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode To: Neil Armstrong Cc: khilman@baylibre.com, kishon@ti.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 9, 2020 at 6:04 PM Neil Armstrong wrote: > > In order to keep OTG ID detection even when in Host mode, the ID line of > the PHY (if the current phy is an OTG one) pull-up should be kept > enable in both modes. > > This fixes OTG switch on GXL, GXM & AXG platforms, otherwise once switched > to Host, the ID detection doesn't work anymore to switch back to Device. > > Signed-off-by: Neil Armstrong Reviewed-by: Martin Blumenstingl