Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH v11 4/5] locking/qspinlock: Introduce starvation avoidance
 into CNA
From:   Alex Kogan <alex.kogan@oracle.com>
In-Reply-To: <8019917d-5e8e-e03d-583c-6809dee7a5c2@infradead.org>
Date:   Tue, 15 Sep 2020 15:57:55 -0400
Cc:     linux@armlinux.org.uk, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Will Deacon <will.deacon@arm.com>,
        Arnd Bergmann <arnd@arndb.de>, longman@redhat.com,
        linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, tglx@linutronix.de, bp@alien8.de,
        hpa@zytor.com, x86@kernel.org, guohanjun@huawei.com,
        jglauber@marvell.com, steven.sistare@oracle.com,
        daniel.m.jordan@oracle.com, dave.dice@oracle.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <5FC23678-02D3-444B-B5AF-74E210026185@oracle.com>
References: <20200915180535.2975060-1-alex.kogan@oracle.com>
 <20200915180535.2975060-5-alex.kogan@oracle.com>
 <8019917d-5e8e-e03d-583c-6809dee7a5c2@infradead.org>
To:     Randy Dunlap <rdunlap@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Sep 15, 2020, at 3:24 PM, Randy Dunlap <rdunlap@infradead.org> =
wrote:
>=20
> Hi,
>=20
> Entries in the kernel-parameters.txt file should be kept in =
alphabetical order
> mostly (there are a few exceptions where related options are kept =
together).
>=20
>=20
>=20
> On 9/15/20 11:05 AM, Alex Kogan wrote:
>> Keep track of the time the thread at the head of the secondary queue
>> has been waiting, and force inter-node handoff once this time passes
>> a preset threshold. The default value for the threshold (10ms) can be
>> overridden with the new kernel boot command-line option
>> "numa_spinlock_threshold". The ms value is translated internally to =
the
>> nearest rounded-up jiffies.
>>=20
>> Signed-off-by: Alex Kogan <alex.kogan@oracle.com>
>> Reviewed-by: Steve Sistare <steven.sistare@oracle.com>
>> Reviewed-by: Waiman Long <longman@redhat.com>
>> ---
>> .../admin-guide/kernel-parameters.txt         |  9 ++
>> kernel/locking/qspinlock_cna.h                | 95 =
++++++++++++++++---
>> 2 files changed, 92 insertions(+), 12 deletions(-)
>>=20
>> diff --git a/Documentation/admin-guide/kernel-parameters.txt =
b/Documentation/admin-guide/kernel-parameters.txt
>> index 51ce050f8701..73ab23a47b97 100644
>> --- a/Documentation/admin-guide/kernel-parameters.txt
>> +++ b/Documentation/admin-guide/kernel-parameters.txt
>> @@ -3363,6 +3363,15 @@
>> 			Not specifying this option is equivalent to
>> 			numa_spinlock=3Dauto.
>>=20
>> +	numa_spinlock_threshold=3D	[NUMA, PV_OPS]
>> +			Set the time threshold in milliseconds for the
>> +			number of intra-node lock hand-offs before the
>> +			NUMA-aware spinlock is forced to be passed to
>> +			a thread on another NUMA node.	Valid values
>> +			are in the [1..100] range. Smaller values result
>> +			in a more fair, but less performant spinlock,
>> +			and vice versa. The default value is 10.
>> +
>> 	cpu0_hotplug	[X86] Turn on CPU0 hotplug feature when
>> 			CONFIG_BOOTPARAM_HOTPLUG_CPU0 is off.
>> 			Some features depend on CPU0. Known dependencies =
are:
>=20
>=20
> This new entry and numa_spinlock from patch 3/5 should go between =
these other 2 NUMA entries:
>=20
> 	numa_balancing=3D	[KNL,X86] Enable or disable automatic =
NUMA balancing.
> 			Allowed values are enable and disable
>=20
> 	numa_zonelist_order=3D [KNL, BOOT] Select zonelist order for =
NUMA.
> 			'node', 'default' can be specified
> 			This can be set from sysctl after boot.
> 			See Documentation/admin-guide/sysctl/vm.rst for =
details.
Will fix that, thanks.

>=20
>=20
> Oooh, that cpu0_hotplug entry is way out of place.  I'll send a patch =
for that.
Sounds good.

=E2=80=94 Alex=