Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3224084pxk; Tue, 15 Sep 2020 13:25:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwySVbn6L7Zjl+xlmgsf/Bt0rvLTs7CxTij6CnMVn9bxuQa7bwW7KtgKlMZRHA3RgycDQwC X-Received: by 2002:a05:6402:1584:: with SMTP id c4mr24657394edv.192.1600201535856; Tue, 15 Sep 2020 13:25:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600201535; cv=none; d=google.com; s=arc-20160816; b=AvlLwKrPJNU1maipTnfMhngMMSKBcjUW3jHlB/w7djRrnNwVSMZSRXfMuMBoZ8MQWA TsTUs9Xb9NjeQXEvHhE3xm9dGv49HOjGH/LRp+hsgOT4lb7cZQN4FZzx9fNLptCaOzKM 8CfPPhzaKb85vtXYop4AuKGNDRp0Pp5f9/QsGstupantllQ9G9H8vELoO/pVl/pD17sE w6rON6w1sUd0bUq4uVlhR0xhuLsKYur7rzrYzQc9YFjNA1uC0SXT6Bkas8ZcieZOJz+U nsBgqb1Z7nlS5sF1Wzec/vWDBUnYcEApvwitidcUuPlAQGdN0Pqpd7fL9JZ4o54eHryy f+3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bF3iN2TYMHRMbpwp4Ubg9ibzl7kFpOr9sTVao/DOQ9s=; b=tJxbJHz7Bdf+kOWw2pvzf2K77wb/zURldQlX6qpUcrx/JguJ+VIdfpq2wPNwfjoWvp i3tgjcpK3jIk3I25zNUlANihLQLTJaI5Bg43GVKOHJeShxUBWUiHq4oZSr23lngSqCCd mF+9pIaMVYXZSANhjB7p5dzoUBVhFofB46s+7dwf5Db4AihIaAERWw8bTntpe2Vupp80 COwH2bCY2IxB+cdtGCYxTAQw6KCHYzlG5A0W8SnOc+GZXPIHG4yEP6Z3nB6BKPbHZyCr O1kg/6mpuhVnXKrk9w2x9HIPddGIuVLGxF1KiS3F6avW/RPXC4AWp7nA3mgpEpoOR77x 37rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=yPINnkBc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v16si10137234eds.222.2020.09.15.13.25.10; Tue, 15 Sep 2020 13:25:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=yPINnkBc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727998AbgIOUWX (ORCPT + 99 others); Tue, 15 Sep 2020 16:22:23 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:56822 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727925AbgIOUS0 (ORCPT ); Tue, 15 Sep 2020 16:18:26 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08FKAxCT178805; Tue, 15 Sep 2020 20:16:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=bF3iN2TYMHRMbpwp4Ubg9ibzl7kFpOr9sTVao/DOQ9s=; b=yPINnkBcp0mtxY9aV+fNBaaQuGQIjo6vTDcK0mpQo/+zUfvdkIqehdgCOO1mp1rEVq9i HGqI8s2G8jlznFL8z3Ad49cQ0Pgje5ki291/AjVNqSciIPPNIVAeEj9Ij6xa5JqX4FpD 2s5pTmeixPZ3jTur6a7FG2iKoig+Fv1Mius3nVpbYfSOlF13Qv9rHvZXOFwcfTeRZ5ay hI3mA18FMgnTXW79xpgTc1XPkiWQQEeUUiBlY3EcunenPlcRdyq4cFgu0vNQt/xKj23S NfrxO0yvQZd4oxXlG8ALpCFfBfaNzg33zLNjsMKDUHeXCG5sPlZQbM/OQ7RJRAepzOEf Uw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 33j91dh0yk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 15 Sep 2020 20:16:40 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08FKFRJ3177333; Tue, 15 Sep 2020 20:16:39 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 33h885xmb0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Sep 2020 20:16:39 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08FKGckp002993; Tue, 15 Sep 2020 20:16:38 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 15 Sep 2020 20:16:37 +0000 From: "Martin K. Petersen" To: Daniel Wagner , linux-scsi@vger.kernel.org Cc: "Martin K . Petersen" , Nilesh Javali , Arun Easi , Martin Wilck , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] qla2xxx: A couple crash fixes Date: Tue, 15 Sep 2020 16:16:23 -0400 Message-Id: <160020074002.8134.15701828723963808362.b4-ty@oracle.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200908081516.8561-1-dwagner@suse.de> References: <20200908081516.8561-1-dwagner@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9745 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009150158 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9745 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 mlxlogscore=999 clxscore=1015 adultscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009150157 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Sep 2020 10:15:12 +0200, Daniel Wagner wrote: > The first crash we observed is due memory corruption in the srb memory > pool. Unforuntatly, I couldn't find the source of the problem but the > workaround by resetting the cleanup callbacks 'fixes' this problem > (patch #1). I think as intermeditate step this should be merged until > the real cause can be identified. > > The second crash is due a race condition(?) in the firmware. The sts > entries are not updated in time which leads to this crash pattern > which several customers have reported: > > [...] Applied to 5.10/scsi-queue, thanks! [1/4] scsi: qla2xxx: Warn if done() or free() are called on an already freed srb https://git.kernel.org/mkp/scsi/c/c0014f94218e [2/4] scsi: qla2xxx: Simplify return value logic in qla2x00_get_sp_from_handle() https://git.kernel.org/mkp/scsi/c/622299f16f33 [3/4] scsi: qla2xxx: Log calling function name in qla2x00_get_sp_from_handle() https://git.kernel.org/mkp/scsi/c/7d88d5dff95f [4/4] scsi: qla2xxx: Handle incorrect entry_type entries https://git.kernel.org/mkp/scsi/c/31a3271ff11b -- Martin K. Petersen Oracle Linux Engineering