Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3231399pxk;
        Tue, 15 Sep 2020 13:38:17 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwn+rfH1A/zirPhaWHFeAsTbjDtvj9+AXcNzT8zZh0+CPN6L9WbVIXEnp2wYRddnODO5ZLa
X-Received: by 2002:a50:da84:: with SMTP id q4mr23643796edj.238.1600202296993;
        Tue, 15 Sep 2020 13:38:16 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1600202296; cv=none;
        d=google.com; s=arc-20160816;
        b=Yz5pHi/COzVdQTFdb7SxZDywrR1aj0vJbOwpb3OmBaeXviDG677k9EU4gvbICxsDZv
         jplrsZiw+iDpaabVTpNEJyVwxfEE3umDXpYLpoIMaI/bbkN5WMAh4YjUagHkoD1LQOR4
         EckBaKuTuLmr11ynVWYjGGqWeYgWP2qvqHkoIfynz2Hwvy3seU48Ae9u8wHItCP2QOAY
         jFimWSrM2lKBiRPYf+ITITnpU7DOir7uhyjHnst1I4Z7vHk0OJv+Qhu/cqwXc4sAM6kT
         sjfyjw+rYuoy3PGuHTvmmQjw3R5jr7cCY0G3405F9KEGsiMtAUi5mJLTjfpvpQibyfPU
         1vMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=9UrYNAuwQKcNag9dW5Ply9EIO8Nad/nvK5+/xjza9a4=;
        b=DT7Du1iBfjDJo49ebl40X26mvPyhbB8ssgL7ryz9QrktZgexF7w/0Vac1fhyxpxSPp
         yoU+DOhXCLwKQcM+wd2bBRr84wQUkr1NS8SRY+IoTW1HoqYV18bhhjP2sbWJVpInf7R6
         ltEsJgBFiaElKAkuog/+lr9LItT6NTBvFVmKRU8LsPDyV3qg7WJQN1EQHcahUz4e6eYb
         kb4XPSmvahMetcqpY6M8fzbF8fTLXXwsRkC4CiEVpw97iuT8QApeNKLKldvXlhH2uL1C
         uKfHvSbXlrN205mMS7UN0zAfnzxL0GkVN2RAuh+5dGPChvT7zTN+bnze86v9hTtlbFM8
         +5mA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=SPiN9yIJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id u16si10727089edo.487.2020.09.15.13.37.54;
        Tue, 15 Sep 2020 13:38:16 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=SPiN9yIJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728011AbgIOUgk (ORCPT <rfc822;ketanpantkp@gmail.com>
        + 99 others); Tue, 15 Sep 2020 16:36:40 -0400
Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:17870 "EHLO
        hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727835AbgIOUdm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 15 Sep 2020 16:33:42 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5f6124f60002>; Tue, 15 Sep 2020 13:32:54 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Tue, 15 Sep 2020 13:33:42 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Tue, 15 Sep 2020 13:33:42 -0700
Received: from [10.21.180.184] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 15 Sep
 2020 20:33:33 +0000
Subject: Re: [PATCH net-next RFC v4 04/15] devlink: Add reload actions stats
 to dev get
To:     Jiri Pirko <jiri@resnulli.us>
CC:     Ido Schimmel <idosch@idosch.org>,
        Moshe Shemesh <moshe@mellanox.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jiri Pirko <jiri@mellanox.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1600063682-17313-1-git-send-email-moshe@mellanox.com>
 <1600063682-17313-5-git-send-email-moshe@mellanox.com>
 <20200914134500.GH2236@nanopsycho.orion> <20200915064519.GA5390@shredder>
 <20200915074402.GM2236@nanopsycho.orion>
 <0d6cb0da-761b-b122-f5b1-b82320cfd5c4@nvidia.com>
 <20200915133406.GQ2236@nanopsycho.orion>
From:   Moshe Shemesh <moshe@nvidia.com>
Message-ID: <bcd28773-0027-11f5-1fd9-0a793f0a3c3a@nvidia.com>
Date:   Tue, 15 Sep 2020 23:33:30 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200915133406.GQ2236@nanopsycho.orion>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1600201974; bh=9UrYNAuwQKcNag9dW5Ply9EIO8Nad/nvK5+/xjza9a4=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:Content-Type:
         Content-Transfer-Encoding:Content-Language:X-Originating-IP:
         X-ClientProxiedBy;
        b=SPiN9yIJoeNijWWwLop+VnoRYo3R4agX+WpOULBR7Ct9zZmDfmW6nzr+p1uFRurjc
         kNeZ8rhNQEadfADyWn0I5gJGEqXyVMyJ+Z6Xyx0813Pc/+yiv+s+TtBnAuf0c/ujDa
         +UKFplnGCxW339r38FKFuK43xVJHfaMXjfv08Qxnw792bN+18QbUlrTXi9LE8pgzy9
         O6R8pvSSH/RyaYnPfCVvVV1N010z/ShyvYNMadPu1TGy+GNbK7A/hLWzEp342VYyBM
         K2rv0EZXK1cFWgRLcFWbIhz80rkObRhoEPQxaStlzI+kWH2TXWbssfLPBmRYNqXBdi
         HhugGEt7no4ZA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/15/2020 4:34 PM, Jiri Pirko wrote:
> Tue, Sep 15, 2020 at 02:31:38PM CEST, moshe@nvidia.com wrote:
>> On 9/15/2020 10:44 AM, Jiri Pirko wrote:
>>> Tue, Sep 15, 2020 at 08:45:19AM CEST, idosch@idosch.org wrote:
>>>> On Mon, Sep 14, 2020 at 03:45:00PM +0200, Jiri Pirko wrote:
>>>>> Mon, Sep 14, 2020 at 08:07:51AM CEST, moshe@mellanox.com wrote:
>>>>>> Expose devlink reload actions stats to the user through devlink dev
>>>>>> get command.
>>>>>>
>>>>>> Examples:
>>>>>> $ devlink dev show
>>>>>> pci/0000:82:00.0:
>>>>>>    reload_action_stats:
>>>>>>      driver_reinit 2
>>>>>>      fw_activate 1
>>>>>>      driver_reinit_no_reset 0
>>>>>>      fw_activate_no_reset 0
>>>>>> pci/0000:82:00.1:
>>>>>>    reload_action_stats:
>>>>>>      driver_reinit 1
>>>>>>      fw_activate 1
>>>>>>      driver_reinit_no_reset 0
>>>>>>      fw_activate_no_reset 0
>>>>> I would rather have something like:
>>>>>      stats:
>>>>>        reload_action:
>>>>>          driver_reinit 1
>>>>>          fw_activate 1
>>>>>          driver_reinit_no_reset 0
>>>>>          fw_activate_no_reset 0
>>>>>
>>>>> Then we can easily extend and add other stats in the tree.
>>
>> Sure, I will add it.
> Could you please checkout the metrics patchset and figure out how to
> merge that with your usecase?
>

I will check, I will discuss with Ido how it will fit.

>>>>> Also, I wonder if these stats could be somehow merged with Ido's metrics
>>>>> work:
>>>>> https://github.com/idosch/linux/commits/submit/devlink_metric_rfc_v1
>>>>>
>>>>> Ido, would it make sense?
>>>> I guess. My original idea for devlink-metric was to expose
>>>> design-specific metrics to user space where the entity registering the
>>>> metrics is the device driver. In this case the entity would be devlink
>>>> itself and it would be auto-registered for each device.
>>> Yeah, the usecase is different, but it is still stats, right.
>>>
>>>
>>>>>> $ devlink dev show -jp
>>>>>> {
>>>>>>      "dev": {
>>>>>>          "pci/0000:82:00.0": {
>>>>>>              "reload_action_stats": [ {
>>>>>>                      "driver_reinit": 2
>>>>>>                  },{
>>>>>>                      "fw_activate": 1
>>>>>>                  },{
>>>>>>                      "driver_reinit_no_reset": 0
>>>>>>                  },{
>>>>>>                      "fw_activate_no_reset": 0
>>>>>>                  } ]
>>>>>>          },
>>>>>>          "pci/0000:82:00.1": {
>>>>>>              "reload_action_stats": [ {
>>>>>>                      "driver_reinit": 1
>>>>>>                  },{
>>>>>>                      "fw_activate": 1
>>>>>>                  },{
>>>>>>                      "driver_reinit_no_reset": 0
>>>>>>                  },{
>>>>>>                      "fw_activate_no_reset": 0
>>>>>>                  } ]
>>>>>>          }
>>>>>>      }
>>>>>> }
>>>>>>
>>>>> [..]