Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3268875pxk; Tue, 15 Sep 2020 14:49:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEJlOJuWjKWqNwMCNKjthUxmr5yFeHc1a6BsXTd/IMyn8Yj7TuMVlTO942c7vdgrGx4ln0 X-Received: by 2002:a17:906:6a52:: with SMTP id n18mr21754554ejs.58.1600206565222; Tue, 15 Sep 2020 14:49:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600206565; cv=none; d=google.com; s=arc-20160816; b=iH9NqpHvusc7/BuLxdju+HcUVBjIN7aQb2nwm1Vx9qdtE2+20Zfad4+QjOObioMWeK CoiV7kMeZcGfqsbCu/pp3ZYVAkgETiHJ0bYeuolzRzKYR7MdwPgtMMwDhkVOffK2o7Kg 2O4B+yjTMst1GEQAxoPL+M7lA53srOsiDew1gsjF7XosyZCqhI0mTYmxBe8EjT6I6shH 9l4eEIEXTwFP6XaabNUNz0ZNOeX+aZGI7/PHJuHGAkx99NdhBclQuPcp7ZKo+yrA6MKz xLoSryJMyxOuuARn4txh+BYqo20r0SDG/eXsH6ayNiv5vCq9cHDffTlvRe6+NCW4rbTh aIIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=gDATj3HQu5NX3oZavtrEX8T1UG7fxQo1Pj8JOqxXU+o=; b=b9GrGUyHIEqHpnzzoJxZqzDWsWfsQ0eB3lSCrI8QFN6T2/z6oVrOfBE1du/wf4eaze XdKRv/RPh27GWZdvMv+EOW9jmOC17bpyZhbqnHTwPlbFi604eA7OX/x4Ea2OJKm5uyFf 2W1ixf5x6tuqV7ktlAoUYF3Ipq1RaMjxEb1Lx+zf2xiOyMJ2QB9SNg5Aum89LdO1SGSa ft9lsthfNjA/eze0xmRm4sfZbuOrtkX0H26JktmLfLY8Z+nF7cpzNsfYf2de7moTtzWM sizGRH8go2VlmHUwkou7mvr7MBGokpskql0WxNErvFwzCS3rfyyC7+I7OXM0hzay69lW LVqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=uQb5YDGR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yc15si11984315ejb.674.2020.09.15.14.49.01; Tue, 15 Sep 2020 14:49:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=uQb5YDGR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728002AbgIOVqs (ORCPT + 99 others); Tue, 15 Sep 2020 17:46:48 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:34984 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728053AbgIOVqV (ORCPT ); Tue, 15 Sep 2020 17:46:21 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08FLSwWt096490; Tue, 15 Sep 2020 21:46:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=gDATj3HQu5NX3oZavtrEX8T1UG7fxQo1Pj8JOqxXU+o=; b=uQb5YDGRqJZ8BQoTIrtCu4YuTgZb2evLd14yOxSBHm2RIdFAFC5Eavn+KFhGlbLK0ZZ1 FRdm/wdR5WFH5VxPuDVXrhYEORylzbZZ9uHblLfNFXB2upQoe3FQNpQTII2iteZ1WTet xKruFtnNSYPIJqajW3VOZLf7lfchHSJ4Hd6/M0qoyXDYGw/MP7kpBmXged7Oi/PEwX/s Xgr2Uzp/G8kLALs51oujYpy3aDpXNTvrNOuCiplJ45srzgt0vVqSYp8HzzhlGIjjtQft 4m0eSdKzVoYbgqZelsEfzJBoCmCqrK47DoNTNfJGpCEaMFTRmDMGsHaTRxsCxgdFMdgg TA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 33gp9m7r5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 15 Sep 2020 21:46:08 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08FLUhtW026571; Tue, 15 Sep 2020 21:44:07 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 33h89031h3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Sep 2020 21:44:07 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08FLi3Ym015438; Tue, 15 Sep 2020 21:44:03 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 15 Sep 2020 21:44:02 +0000 To: Jing Xiangfeng Cc: , , , , Subject: Re: [PATCH] scsi: esas2r: prevent a potential NULL dereference in esas2r_probe() From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20200909084653.79341-1-jingxiangfeng@huawei.com> Date: Tue, 15 Sep 2020 17:44:00 -0400 In-Reply-To: <20200909084653.79341-1-jingxiangfeng@huawei.com> (Jing Xiangfeng's message of "Wed, 9 Sep 2020 16:46:53 +0800") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9745 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=1 mlxscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009150168 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9745 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=1 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009150168 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jing, > esas2r_probe() calls scsi_host_put() in an error path. However, > esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead. Wouldn't it be better to move the scsi_host_put() call after the error message? -- Martin K. Petersen Oracle Linux Engineering