Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3287162pxk; Tue, 15 Sep 2020 15:25:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQRdBHNs3Z48r+EMh6KDPJa4G1JP+s0XUnj18KTOG+tAwhTG4hmgJ1Gfa7Mr+sz6PYknB9 X-Received: by 2002:a17:906:194b:: with SMTP id b11mr21964579eje.159.1600208727424; Tue, 15 Sep 2020 15:25:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600208727; cv=none; d=google.com; s=arc-20160816; b=kW1ib/c+YWa4GGpW13aTuAdiMhOASpDSlZxd3EWrIzulug2g3vaeo16RFa8Mw9fiMY qot9NIaZIY0mwxBmQl5HWDdl+Y6mXvDkggfjDleJFfbf925S8Wpt20gpWYUY1TKhVR8f 88s7BOp2ZgYOiG2eqfhPQ0xLrrUog04dFRXune8zGILhoGZlbQmooxYEWXUGlyv2nUuJ o74VY5stwmtK4KnVCxSMxNlr38bVH2ZyEjxYXnvOxu5X7ptgcpklCLectr4SSSp1ZxNJ SYst3Pr70DUWd38V9c4gk05n8+lhCYzFcQ2oPxSw1dK5SwpHcAW9ddIb0+b/jwamznu2 pnnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=yWuQfWVE3+JWUaLd+cQOqwkcpY5VPJ2if6vhJrp5yOQ=; b=XPE/jhNQLrQ044+TzZBfRkYRt6q2Ou3etigGfdfBKp+mYCeeGADaIGrAm4yStU0MUB 1ERIW1s5XOznoX9HyPNlIOInb/xzFjWlxk68yjNXLCYMfje1aQS4ImR93+ob+nQcZ7E+ 1eAdJA8M8FGrBY8CrJkguMwlKQa13y0bjuNJIFoNVsycljgxKOTmKMQ6vAXHn6lSZ0yf c/7+GoG/DT4ZkPybYvjFE+DZQ6MIXjZVYcq5qdA38XDgsGUZVBGGeMHtbUPR7cvlNECv YTgrYT/Cr+8JqsL7XZ1W0LN5sJqEq6zswuuNUuwU6iMt/6en9sA6fVFLLtYqzjUrs6fK PwHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gv22si10440758ejb.536.2020.09.15.15.25.04; Tue, 15 Sep 2020 15:25:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727714AbgIOWX5 (ORCPT + 99 others); Tue, 15 Sep 2020 18:23:57 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:49606 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727547AbgIOQYG (ORCPT ); Tue, 15 Sep 2020 12:24:06 -0400 Received: from ip5f5af089.dynamic.kabel-deutschland.de ([95.90.240.137] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kIDSo-0006Xe-Jb; Tue, 15 Sep 2020 16:05:50 +0000 Date: Tue, 15 Sep 2020 18:05:49 +0200 From: Christian Brauner To: Kees Cook Cc: linux-kernel@vger.kernel.org, Thadeu Lima de Souza Cascardo , Max Filippov , Michael Ellerman , Christian Brauner , Andy Lutomirski , Will Drewry , linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 09/15] selftests/seccomp: Convert REGSET calls into ARCH_GETREG/ARCH_SETREG Message-ID: <20200915160549.5ct5lpwvdzzm7cvn@wittgenstein> References: <20200912110820.597135-1-keescook@chromium.org> <20200912110820.597135-10-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200912110820.597135-10-keescook@chromium.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 12, 2020 at 04:08:14AM -0700, Kees Cook wrote: > Consolidate the REGSET logic into the new ARCH_GETREG() and > ARCH_SETREG() macros, avoiding more #ifdef code in function bodies. > > Signed-off-by: Kees Cook > --- Looks good! Acked-by: Christian Brauner