Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp3290187pxk; Tue, 15 Sep 2020 15:31:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0HZXn2yAwsIBYjHAbXKoUw03j9lcLDtZyJJ0wpqbkt+0EzNqs/ShlFGRHix8ZcNYkOJWa X-Received: by 2002:a50:ab59:: with SMTP id t25mr23921475edc.364.1600209105326; Tue, 15 Sep 2020 15:31:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600209105; cv=none; d=google.com; s=arc-20160816; b=QsSakJB5PuhM4IlBsJ1AHnitc7jfGsFmM1HJvGGSmJgL9kWG15fyhYRVVRvLbwLI5v u0GWZGYDQY5BBDw2g0WpHQEvvImYpUVrRROgmS3VdYNWrtQPxf9p7mkuwsOhjO3/jLgl 0i7wWrJ0ZitKq87Y1vqmSDIzF7ixkV/QXRiU8wY19JiL9ijtUFdZattNnxX77rBg2Jnl doymE31Fphc5xuuxOYa6PxFgBTg14KL3StHA16ceg2oYni/lftvCTa/2BD7ksnWDrVU9 6PgdBjiikaA9YWR0aDhtKPh8M7uUCwm+AoQv5XFYT9apNNCOIK8+Gg4OPu1vYUWss5wp 42Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JPZAxtgrpswTwwEctIAirCTKHMKMYlH6dKc5JaMDl+Q=; b=iS9ZqxltXUUsPDF0vLZ9GrrXzGfKuto1VenJ+XTdghPC32chowvjSAQOpos+YJIuDO CX4a9KGYmma0s4Z9Nvp8yReK2vEnlEyf06lclq/emmm1F4t3EWvDh6DhPZexw2OVuQtP Ha7pE6FTcCDLyIn5VSKceljIzZBCA7wrTqXQJ0SVBkNZjdP+QzJI6w2wxv0wKOW/NwRC dxHKSlN0TzKnJtZo3MxTPSroyRcmCLfAjyXbu7pYbiidnBri8ciZhWfea8ib2cDZifOc JjN9/Sje9ZmHQ55zTFkBsIYohVoYlKbIhlYBUC4fu4LjBsCoaBLgCYaoJ6hAU3+pQ/6v AEBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ugddvVXP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d9si10272228edv.452.2020.09.15.15.31.23; Tue, 15 Sep 2020 15:31:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ugddvVXP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727648AbgIOW2x (ORCPT + 99 others); Tue, 15 Sep 2020 18:28:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727598AbgIOQTx (ORCPT ); Tue, 15 Sep 2020 12:19:53 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 969B8C061797 for ; Tue, 15 Sep 2020 09:19:32 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id g29so2264381pgl.2 for ; Tue, 15 Sep 2020 09:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JPZAxtgrpswTwwEctIAirCTKHMKMYlH6dKc5JaMDl+Q=; b=ugddvVXPv0zV3H78FDJq245N95jL3nKJt24tR7I7m1pkIrlVBV4vo6rsKzl+SG4uOB sUk8Gx5Z4uU1etfRE2XF67AXCujQNSl/9CDoH2sjlmTNtG4dlxaay11Dxime1JZJVNxS wVt+mOJMw0TWFVnDndw00pySAAC6SecnAkfyk0seXyV9Nv2tTB2biZpL8bSQ3m7SCFWw HEWAm0XX0/NqferzgsoepaOrApKxzY14QlR46WlhPuYKUR/D2L/yBvx+8IosL5T9zE8N lcXEGMb17S4zhJLVzSsxvUfT3dNAnzZvd6w/RXhA6jWBWbDaQ2VN6P63QtXEhrGwNAE7 779A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JPZAxtgrpswTwwEctIAirCTKHMKMYlH6dKc5JaMDl+Q=; b=bCuYJhMwfKFVuR/UwariAA72oe4AYAQZA4yEeVXqBiEp4gkTPLvXlXKB6Rmn2yX0eu MbUJLchTCWSQy/3o417QdkGrHcmLNt9t1fofzQlScItc0+W8Tn8d16DDmNv3DusQAM+j Aq/VgBRlAvIVdQekPOV1N0itoKZQP+fx80N4YFXL2HFnMja7ZiCVTQEqmKlLQ5cUxyjR 1gYQUtc7nDkdNVaaiySMQxu8eAkTzHkCEtwBB9cAsD4g7HOSNdwPWei7Civ/sl25024x S/Qa9qstw/TzdHLHO//bUvxcCkFWdGAQ7XEdEI0gQhqHsnIQqUo4S0q9z5wkFaifs8ry GdeQ== X-Gm-Message-State: AOAM531rMvKW8T+LzMv9i5zz6NWO+/yeHqDxQR9+C9jq0jPb9p8vikDJ 05VcF175vyJkgz4p2DREd5+IFZqjSp+cgGw= X-Received: by 2002:a05:6a00:844:b029:13f:dd99:d1a4 with SMTP id q4-20020a056a000844b029013fdd99d1a4mr10486133pfk.31.1600186771631; Tue, 15 Sep 2020 09:19:31 -0700 (PDT) Received: from linux ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id y203sm13707305pfb.58.2020.09.15.09.19.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Sep 2020 09:19:31 -0700 (PDT) Date: Tue, 15 Sep 2020 21:49:25 +0530 From: Manivannan Sadhasivam To: wg@grandegger.com, mkl@pengutronix.de, robh+dt@kernel.org Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dev.kurt@vandijck-laurijssen.be, o.rempel@pengutronix.de Subject: Re: [PATCH 0/6] Add support for MCP25XXFD SPI-CAN Network driver Message-ID: <20200915161925.GA5660@linux> References: <20200910133806.25077-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910133806.25077-1-manivannan.sadhasivam@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Sep 10, 2020 at 07:08:00PM +0530, Manivannan Sadhasivam wrote: > Hello, > > This series is the continuation of the work done by Marc Kleine-Budde on > adding support for Microchip MCP25XXFD SPI-CAN driver [1]. I've taken the > patches from Marc's tree [2] and posted with an additional MAINTAINERS > patch on top since he seems to be very busy. This series has been tested > on RB5 board featuring MCP2518FD transceiver. > > Marc: I'd like to co-maintain this driver in upstream hence added myself > as the co-maintainer. Shout at me if you do not want it! Also I've removed > the v4x tag since I don't think all the versions are posted to mailing > list. > > I'll add my review on top of this posting. > Just a quick question: I don't see any activity on this specific driver for sometime (back in Martin days itself). Is it due to lack of reviewers or it is due to the patch size (lines of code) so that nobody is interested in reviewing? How are we going to move forward? Thanks, Mani > Thanks, > Mani > > [1] https://www.spinics.net/lists/linux-can/msg03712.html > [2] https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=mcp25xxfd-47 > > Kurt Van Dijck (1): > can: mcp25xxfd: add listen-only mode > > Manivannan Sadhasivam (1): > MAINTAINERS: Add entry for Microchip MCP25XXFD SPI-CAN network driver > > Marc Kleine-Budde (3): > can: rx-offload: can_rx_offload_add_manual(): add new initialization > function > can: mcp25xxfd: add regmap infrastructure > can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN > > Oleksij Rempel (1): > dt-bindings: can: mcp25xxfd: document device tree bindings > > .../bindings/net/can/microchip,mcp25xxfd.yaml | 79 + > MAINTAINERS | 8 + > drivers/net/can/rx-offload.c | 11 + > drivers/net/can/spi/Kconfig | 2 + > drivers/net/can/spi/Makefile | 1 + > drivers/net/can/spi/mcp25xxfd/Kconfig | 17 + > drivers/net/can/spi/mcp25xxfd/Makefile | 8 + > .../net/can/spi/mcp25xxfd/mcp25xxfd-core.c | 2884 +++++++++++++++++ > .../net/can/spi/mcp25xxfd/mcp25xxfd-crc16.c | 89 + > .../net/can/spi/mcp25xxfd/mcp25xxfd-regmap.c | 556 ++++ > drivers/net/can/spi/mcp25xxfd/mcp25xxfd.h | 828 +++++ > include/linux/can/rx-offload.h | 3 + > 12 files changed, 4486 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/can/microchip,mcp25xxfd.yaml > create mode 100644 drivers/net/can/spi/mcp25xxfd/Kconfig > create mode 100644 drivers/net/can/spi/mcp25xxfd/Makefile > create mode 100644 drivers/net/can/spi/mcp25xxfd/mcp25xxfd-core.c > create mode 100644 drivers/net/can/spi/mcp25xxfd/mcp25xxfd-crc16.c > create mode 100644 drivers/net/can/spi/mcp25xxfd/mcp25xxfd-regmap.c > create mode 100644 drivers/net/can/spi/mcp25xxfd/mcp25xxfd.h > > -- > 2.17.1 >