Received: by 2002:a4f:b056:0:0:0:0:0 with SMTP id m22csp2660853ivi; Tue, 15 Sep 2020 16:00:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNcnLAl9UEcL182AsyaDu/vgqbJLcKHvkvXmZL2DzZVE/92mlnwzvxJ53J1WsjURoqXQiZ X-Received: by 2002:a17:907:72c2:: with SMTP id du2mr23255612ejc.512.1600210814272; Tue, 15 Sep 2020 16:00:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600210814; cv=none; d=google.com; s=arc-20160816; b=1Bt2pgnvrmLvKZbG0M19cbiWFmZ9+WvRD4E+eS+ebEAWkeJCJ7YuGtEzlg1FKwUs4v i3ginncPnE6sIl53qpHtiELkpb6qv77YDBss7Uulxclnk48piibuBISjr76qATiAh41r RgS/WOdy5V06wa03OCjUVhhb0vd/q5HaG3Zua6gjSxi17YYchpyFrBcwMC5E42pJ9Akj a9HjJFa9kKdTwJFHb6wrbd9c7dg8rO3xhon+InEm1+3N2YPJuY9yi180cauUF7fqC2YP ISMZ2UVxac9psR0YfpEm3fCWAQKkHzrtKewoT3C1qjtijgRGAK3XZF0C+NP1+rYSbwqt OxjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=lTM/Sw4S4AW5nxKuw1OGdX/2LHUMbGTrKEjjZ4iI8lg=; b=VAVzB3itZD1qQZYS+EIge9GnPOl+e/DPd23dypdJ5LkcmVyoXbErKtreWmpK88bbPJ 49KLgnG2B+B4K/JmLNtVjUAUM7mFlgjtQW7toc3FI6snVHTnFr2TgfUYTMrwS4YBoq0s xqqmY1TrtxGj4NoIK8Q+LD9+7I+Wi30nCw2rHEX7coZrTtU0ywJ91gXjPoNIIcOR6Xgh 1dYkYYxcialsK+w8Tk7cz0qwpINoSV9e6LgR2amQaZxg1kc6+kMbovRdL4BmfPJ01dpn cRztyDS2qGZZLel6bgJ9/xxF8t89b6T1re0BLMBIyz+0TCC6fClY7XaGByAFlaRgc9QM MBqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ygYgM9m/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j17si10073279ejc.26.2020.09.15.15.59.52; Tue, 15 Sep 2020 16:00:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ygYgM9m/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727448AbgIOW7Q (ORCPT + 99 others); Tue, 15 Sep 2020 18:59:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:34454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727426AbgIOPIQ (ORCPT ); Tue, 15 Sep 2020 11:08:16 -0400 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0974F20735; Tue, 15 Sep 2020 15:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600182485; bh=0xyXwfxoIK/ZtHtyv1UhPApx13+V3AjswVKHmWQ82cw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ygYgM9m/bn66TFThps3RBp45NivF6dFd2IrQJ/yJlDwq+o3zu/o2aXDe6+eKuDFFz PLLsQ5OEiyl8vcGmQlSZWp4uw3iOkasAeQDPaNPVyDxLa52lXu5nBpOszYtGNCwRIM hbR9tQ38wmTvZhW+cfAbHF0TeKDmXRRnJU7erbZk= Received: by mail-oi1-f169.google.com with SMTP id w16so4261576oia.2; Tue, 15 Sep 2020 08:08:05 -0700 (PDT) X-Gm-Message-State: AOAM531F8ap7J0dJU1XWJGrxggT/aZsMubkyEK7G88FkSdI52fQMwtVC IhP+FTEgkEB01Kq2blNlwyg3KC5Nca4ZU26xqdM= X-Received: by 2002:a54:4517:: with SMTP id l23mr3918280oil.174.1600182484304; Tue, 15 Sep 2020 08:08:04 -0700 (PDT) MIME-Version: 1.0 References: <20200819143544.155096-1-alex.kluver@hpe.com> In-Reply-To: <20200819143544.155096-1-alex.kluver@hpe.com> From: Ard Biesheuvel Date: Tue, 15 Sep 2020 18:07:53 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/2] UEFI v2.8 Memory Error Record Updates To: Alex Kluver Cc: linux-edac@vger.kernel.org, linux-efi , Linux Kernel Mailing List , mchehab@kernel.org, Borislav Petkov , russ.anderson@hpe.com, Dimitri Sivanich , kluveralex@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Aug 2020 at 17:36, Alex Kluver wrote: > > The UEFI Specification v2.8, Table 299, Memory Error Record has > several changes from previous versions. Bits 18 through 21 have been > added to the memory validation bits to include an extended version > of row, an option to print bank address and group separately, and chip id. > These patches implement bits 18 through 21 into the Memory Error Record. > > Change reserved field to extended field in cper_sec_mem_err structure > and added the extended field to the cper_mem_err_compact structure. > > Print correct versions of row, bank, and chip ID. > --- > v1 -> v2: > * Add static inline cper_get_mem_extension to make > it more readable, as suggested by Borislav Petkov > > * Add second patch for bank field, bank group, and chip id. > --- > Alex Kluver (2): > edac,ghes,cper: Add Row Extension to Memory Error Record > cper,edac,efi: Memory Error Record: bank group/address and chip id > > drivers/edac/ghes_edac.c | 17 +++++++++++++++-- > drivers/firmware/efi/cper.c | 18 ++++++++++++++++-- > include/linux/cper.h | 24 ++++++++++++++++++++++-- > 3 files changed, 53 insertions(+), 6 deletions(-) > For the series, Acked-by: Ard Biesheuvel