Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200915140141.42876-1-yuehaibing@huawei.com>
In-Reply-To: <20200915140141.42876-1-yuehaibing@huawei.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Tue, 15 Sep 2020 11:25:02 -0300
Message-ID: <CAOMZO5BOBqCoLgM=yHBKFdM3oXR91mDdRnJY1gOyGmQWiMq+Dg@mail.gmail.com>
Subject: Re: [PATCH -next] clk: imx35: Make mx35_clocks_init static
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Sascha Hauer <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-clk <linux-clk@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi YueHaibing,

On Tue, Sep 15, 2020 at 11:02 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix sparse warning:
>
> drivers/clk/imx/clk-imx35.c:251:12: warning:
>  symbol 'mx35_clocks_init' was not declared. Should it be static?

This is not the correct fix. mx35_clocks_init() was only used by imx35
board files.

Now that imx35 board files are gone, this function can be removed.

I will send a patch removing it.