Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp46054pxk; Tue, 15 Sep 2020 17:20:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwb6wJCkw9P47nVwq3NE1Tn2+UTXAbXxym0XHY1ldAB9sLJOCkBQugnRAD5hL7UkMWO4oLj X-Received: by 2002:a17:907:9ed:: with SMTP id ce13mr21965295ejc.180.1600215615490; Tue, 15 Sep 2020 17:20:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600215615; cv=none; d=google.com; s=arc-20160816; b=LibyLHN8qYAwczyVwrlEKdHKSv9q117oI/UOg15a/LrouC6g0HoqoG3XOqBeWax6vQ ant9N0XS3JIrgYakJ8MYSE4hiASeZwm3j7IN4Ap/SQMtCHb8VoMIo97OkpWWedv3zIh7 jZkGqdZG1ckqKY17ThyA0p0BD04Wbq1+FNvXBP81dVIv0W/gg6LfsW+IvocK53ZuMObB kjirOX8eGYiZoY5eFY9hnYhvahNGFskAwlZdYU2phlp6mYOi3eNYaCx+EtlIhtky45rS eK4oWFQeaR/PxOB4wvFfYyp9fEDt/IODixZcp2ZwIrZ/TICz1Q6FK2uNmM56ZSs2ioAk iD0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature:dkim-signature; bh=m1axPcGZV8fBedPKWqbpNgQ6uP7jhjMe6CHhdUl68Cw=; b=yKcFOM058KZ5WcOC4DWAxpPlaj3SpJFbRngKS1yUIUpy94n7lliY60Qqvw//JAFqT6 kdnwm14lWqJXA10pqKHqUNGPZvK9nJuC7OOQQuj5YNskDlPuC2X/y15jfwLPojrpnomI cy7+XfpjsfA4vvYwIP/SPZqXjzKQGUS7KoLiirxU4WzkEeg3WAl6YO6WVlcp/zimZTKF kfAPPliKptZ21M1eY6H6UVufjov8Ei3paGEyLDLSWSZxKq1FPyMuddS+M5awKQOBP/by V5t28LaX1UztcGnvk92AiIHiTmTN+cj2F/0lL/vP0KGKwqtCn3qGq8vyNfk0yzjdk6QW 1FqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=ZDUvluzG; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=ZDUvluzG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k25si9862128edq.156.2020.09.15.17.19.53; Tue, 15 Sep 2020 17:20:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=ZDUvluzG; dkim=fail header.i=@hansenpartnership.com header.s=20151216 header.b=ZDUvluzG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726451AbgIPART (ORCPT + 99 others); Tue, 15 Sep 2020 20:17:19 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:34626 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbgIOOW6 (ORCPT ); Tue, 15 Sep 2020 10:22:58 -0400 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 9BF068EE188; Tue, 15 Sep 2020 07:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1600179008; bh=+R+IKAKZQYkLR7KIiLxpuuPm5bZnjzeal3GKWrEShUo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ZDUvluzGV6yKCC/nF9wrKzitsx/6M3Qz4Dv0CFUEt0vmhscavKWlYegA3t3D9AtoS cgl18SKCLQ6g+fOWhOlSE1rajdI6kKqsO/3XSzI9vcO6roMQjXQ+sBvii1pDKecG7Q 7/nP62+cOOfIkefYX7rGreL2C+Tu2bzmyrkPw+GQ= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o2D0dkS7cauB; Tue, 15 Sep 2020 07:10:08 -0700 (PDT) Received: from [153.66.254.174] (c-73-35-198-56.hsd1.wa.comcast.net [73.35.198.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 329868EE107; Tue, 15 Sep 2020 07:10:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1600179008; bh=+R+IKAKZQYkLR7KIiLxpuuPm5bZnjzeal3GKWrEShUo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ZDUvluzGV6yKCC/nF9wrKzitsx/6M3Qz4Dv0CFUEt0vmhscavKWlYegA3t3D9AtoS cgl18SKCLQ6g+fOWhOlSE1rajdI6kKqsO/3XSzI9vcO6roMQjXQ+sBvii1pDKecG7Q 7/nP62+cOOfIkefYX7rGreL2C+Tu2bzmyrkPw+GQ= Message-ID: <1600179006.5092.6.camel@HansenPartnership.com> Subject: Re: [PATCH 07/17] 53c700: improve non-coherent DMA handling From: James Bottomley To: Christoph Hellwig Cc: Mauro Carvalho Chehab , Thomas Bogendoerfer , Joonyoung Shim , Seung-Woo Kim , Ben Skeggs , Marek Szyprowski , Tomasz Figa , Matt Porter , iommu@lists.linux-foundation.org, Stefan Richter , linux1394-devel@lists.sourceforge.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, nouveau@lists.freedesktop.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org Date: Tue, 15 Sep 2020 07:10:06 -0700 In-Reply-To: <20200915062738.GA19113@lst.de> References: <20200914144433.1622958-1-hch@lst.de> <20200914144433.1622958-8-hch@lst.de> <1600096818.4061.7.camel@HansenPartnership.com> <20200915062738.GA19113@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-09-15 at 08:27 +0200, Christoph Hellwig wrote: > On Mon, Sep 14, 2020 at 08:20:18AM -0700, James Bottomley wrote: > > If you're going to change the macros from taking a device to taking > > a hostdata structure then the descriptive argument name needs to > > change ... it can't be dev anymore. I'm happy with it simply > > becoming 'h' if hostdata is too long. > > > > I already asked for this on the first go around: > > And I did rename them, those hunks just accidentally slipped into > patch 12 instead of this one. Fixed for the next versions. Ah, yes, found it ... thanks for doing that! James