Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp57747pxk; Tue, 15 Sep 2020 17:43:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6x2e9u4+q/frxH4OvjCWB/PaPlRn7wBcvgEvEMX1GJq1cZdkdqYJR6mkYb0Cbx9p3awiV X-Received: by 2002:a05:6402:1b1d:: with SMTP id by29mr24736455edb.96.1600217010666; Tue, 15 Sep 2020 17:43:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600217010; cv=none; d=google.com; s=arc-20160816; b=NUYZxwww7cvd0MGEq06w95teiQx+85imNXfxPU+6u7Z7nq9cBA1E6qyvaYAoWYJ26U uiScDyGNFUkUC3c1RbD0OPukCejdxWwnRv3h2vO9fhyPZNuc1dyaglqa4CrLNv2odZ/6 ZUTA++/58M0X99fCVGbH7mDV/wapFx58gcvpGDrqAxgwhP++udBM2E0QV450bdE9VbWK /zeLOWnFdiz/DKPtzR3u1UC39/ErzFFXv9ERyYixgUwOFpFn5Q0l5tvNNquo3sqKv4Zd DBxNyvIzq3OSHHiyujhvTJiDJhNfdUgMVQzFP3B9/p8cMbh0PXE7TGlVD01rWkL6jVKF +s0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Rc6KaAEAFGC1bquGjMDTwVXCIGizoAvEk7c9RDuLwUU=; b=kwH6VT/j/yinqzXG+YFGP9a/+vJyl/Sr9f7E6ZqT2LvcC4ZygeOpvHY8r6aRwP9f1M 5L8NBbaK2Jux6DN0O4NhQrBawe8EEKkNhh76Qak9/pN/D+55tzRY+QP17Yc2tT8hv1jt GtDkR+lxYQUJw+KKPPcvjq45vna1ybrCHChimqpLnZJkqfi5ZtmWqUz6KTywoVmCz0nj xnfUV+eZ44EFtW+VwL1ckWkjp9pDbdgazBnSFZuIBV4qsahIZ+4/ebsvvrEF9udyQrK5 X5nlMO6UHZAbh0Fq/ED8/NNmHxrvKkE7Y4yF0/5pKXu0c88s+L5bViBP+ZBcwhIuOnZS nLHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=uHSTTG9S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt15si10267525ejb.22.2020.09.15.17.43.07; Tue, 15 Sep 2020 17:43:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=uHSTTG9S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726343AbgIPAm0 (ORCPT + 99 others); Tue, 15 Sep 2020 20:42:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726587AbgIONCz (ORCPT ); Tue, 15 Sep 2020 09:02:55 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FB2BC06174A for ; Tue, 15 Sep 2020 06:02:54 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id x18so1308438pll.6 for ; Tue, 15 Sep 2020 06:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Rc6KaAEAFGC1bquGjMDTwVXCIGizoAvEk7c9RDuLwUU=; b=uHSTTG9SkzuWvTWWD5CiQWnUreepxjLDXUrW6B7M7673ifJte619xFMebuGUKkNww4 bG8GTdnqecPbRu3IgxB4aRhc+mexcZ6eN5KK4euTNlp1gKFzKVIe2ts+PlcKiAmuLIqB fJL2tItNCkXJnufEmBCgqWlq5wG3sztMd+FCYu3K9zqquLZLCWBQkEiDPszHTdxnh+XG AInVgU+TUJ4lHuE/KgghIeubyhwp46t68stuqmwWJhvQcXxlvrJTeuCJligdwBHyl5sX J42JWxskVo5f+N42nvYckziJh+S0GXbYzGCMVi73KNgTcE+sdpR3ZacUacGUKjQ1KLCf cHDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Rc6KaAEAFGC1bquGjMDTwVXCIGizoAvEk7c9RDuLwUU=; b=e+q7IWR9/VHG/xcPldEMURo8ptoGR5yky22AtQLS3UMyRTACmVHVxWtNm3Z7FleuZf vy8ts6qtUlQeVa8WxEbaJc73/SarBL2r63xK33FD+9yY4Wrgeb1gnGxZmPGC6hcp77g1 +d2574ao7tcpWZxvGkgbofjsYyhcDgwL+us5AsOcydouGQDIq4p8N3KA+QPk8F9epRbf pPyihW0AqFJvD7nd4lW2HzEz7YRX2wXzmIqLrhyj8rPSfMafM5qGme2ZF5APag0M8ry+ B9RNO8wTyJh17vazE2upssOCDbm0xLQMuUG264sN8Dh81ygrxjv3j+Se1KHyVrnIq/1+ D7Qw== X-Gm-Message-State: AOAM531GVKqpgzZ/RNzJHJfnY2iDQ1Y+ZndvGk5shyxQschj/UIRGWfQ TRQNjI2aGCrd7Zw1rG755HcK9A== X-Received: by 2002:a17:90a:72c7:: with SMTP id l7mr4186306pjk.19.1600174973787; Tue, 15 Sep 2020 06:02:53 -0700 (PDT) Received: from MacBook-Pro.local.net ([103.136.221.73]) by smtp.gmail.com with ESMTPSA id c5sm12133263pgj.0.2020.09.15.06.02.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Sep 2020 06:02:53 -0700 (PDT) From: Yinyin Zhu To: viro@zeniv.linux.org.uk, axboe@kernel.dk Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, zhuyinyin@bytedance.com Subject: [PATCH] io_uring: fix the bug of child process can't do io task Date: Tue, 15 Sep 2020 21:02:45 +0800 Message-Id: <20200915130245.89585-1-zhuyinyin@bytedance.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org when parent process setup a io_uring_instance, the ctx->sqo_mm was assigned of parent process'mm. Then it fork a child process. So the child process inherits the io_uring_instance fd from parent process. Then the child process submit a io task to the io_uring instance. The kworker will do the io task actually, and use the ctx->sqo_mm as its mm, but this ctx->sqo_mm is parent process's mm, not the child process's mm. so child do the io task unsuccessfully. To fix this bug, when a process submit a io task to the kworker, assign the ctx->sqo_mm with this process's mm. Signed-off-by: Yinyin Zhu --- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index f115fff39cf4..f5d6bd54a625 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -514,7 +514,7 @@ static inline void io_queue_async_work(struct io_ring_ctx *ctx, } req->files = current->files; - + ctx->sqo_mm = current->mm; spin_lock_irqsave(&ctx->task_lock, flags); list_add(&req->task_list, &ctx->task_list); req->work_task = NULL; -- 2.11.0