Date: Mon, 31 Jul 2006 23:31:34 -0700
From: Andrew Morton <akpm@osdl.org>
To: Olaf Hering <olh@suse.de>
Cc: benh@kernel.crashing.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix link error in atyfb with backlight disabled
Message-Id: <20060731233134.d7477be8.akpm@osdl.org>
In-Reply-To: <20060731185220.GA5127@suse.de>
References: <20060731185220.GA5127@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1666
Lines: 44

On Mon, 31 Jul 2006 20:52:20 +0200
Olaf Hering <olh@suse.de> wrote:

> 
> aty_bl_set_power is only defined if CONFIG_FB_ATY_BACKLIGHT is enabled.
> 
> Signed-off-by: Olaf Hering <olh@suse.de>
> 
> Index: linux-2.6.18-rc3/drivers/video/aty/atyfb_base.c
> ===================================================================
> --- linux-2.6.18-rc3.orig/drivers/video/aty/atyfb_base.c
> +++ linux-2.6.18-rc3/drivers/video/aty/atyfb_base.c
> @@ -2812,7 +2812,7 @@ static int atyfb_blank(int blank, struct
>  	if (par->lock_blank || par->asleep)
>  		return 0;
>  
> -#ifdef CONFIG_PMAC_BACKLIGHT
> +#if defined(CONFIG_PMAC_BACKLIGHT) && defined(CONFIG_FB_ATY_BACKLIGHT)
>  	if (machine_is(powermac) && blank > FB_BLANK_NORMAL)
>  		aty_bl_set_power(info, FB_BLANK_POWERDOWN);
>  #elif defined(CONFIG_FB_ATY_GENERIC_LCD)
> @@ -2844,7 +2844,7 @@ static int atyfb_blank(int blank, struct
>  	}
>  	aty_st_le32(CRTC_GEN_CNTL, gen_cntl, par);
>  
> -#ifdef CONFIG_PMAC_BACKLIGHT
> +#if defined(CONFIG_PMAC_BACKLIGHT) && defined(CONFIG_FB_ATY_BACKLIGHT)
>  	if (machine_is(powermac) && blank <= FB_BLANK_NORMAL)
>  		aty_bl_set_power(info, FB_BLANK_UNBLANK);
>  #elif defined(CONFIG_FB_ATY_GENERIC_LCD)

Linus merged a patch today (powermac-more-powermac-backlight-fixes.patch)
whcih changes all this stuff.  Its changelog included a mysterious "More
Kconfig fixes".

So can you please see if current -git is indeed fixed?

Thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/