Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp60674pxk; Tue, 15 Sep 2020 17:49:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPgunmQzbZ5XjvUyCrBWeGjarQjUSmOz445+Drl3PLh7Ecr6hw/vRxP5e3vagSMDr4Ftr/ X-Received: by 2002:a05:6402:138a:: with SMTP id b10mr25179056edv.113.1600217399766; Tue, 15 Sep 2020 17:49:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600217399; cv=none; d=google.com; s=arc-20160816; b=xyRegdHlPPuJ9XQf4qdQDydrrfkbKkoKKXmga+NCY1z80ymH23J9fO4lqDJ/PHyh9y SKEwS4aUorcRUfR5A/FXe5NZlWZa2Aa7OlqG1SLHlj4JXFxu39JgH87mbYBoBgdFq+zA t7Z04ebtvGNS8kNwU9pPoYxeXqFXZm56yzGJoeIyn/Guz6I80WVeUkMsnlO+3kCshyoR 9QTN57NxQcjz+FBU0bJekZgFWiE3B4oZPhpkGEAPzdQmRPNvrdafYOU8QqlUr56mFxwm 7/mR2U7vd+kfQP1kQQ/yprhoHBI9mj3N8Gf4+p7NDqyxWTt5fYp2uQir3lv6gw2KU6yf 57PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=RbIXkb4A9Pah/AuRw5l3lgFrjL/x0QoVobRUslt38cU=; b=VGSs12RhEvPVRTyfs/cA65eHZcpC9uD+NjnYTuiiG3ygPeJlaE7sezTgQJu7pA/6Td ui2UIQbQMv73BmAEptXLUf6hIo2VwAwmgnxItLYiVUT50xQd56YVg/Kx5jP6mrfU5OW2 JhLNPZ3v5hTC6eKxCIwqQfbobwrDmadm6NDoYk1XwqGCb1/yJEoHsi0y0ybmgx2OviA5 VPQINCG1ri5/ijW2BFAQLZq0YJoxcvuj0ACTX57eY+S/9AUM85WIvnD3NtA74faNq3do IMPGmR38JIxkGmSoSaNqC2Gp5SfgiIBSxtASxutzRRjv8Cjd3MbGM779pQ3jvl2VyeHP sSaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bVYT1hmr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lu21si10537435ejb.482.2020.09.15.17.49.37; Tue, 15 Sep 2020 17:49:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bVYT1hmr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726750AbgIPAtD (ORCPT + 99 others); Tue, 15 Sep 2020 20:49:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:45392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726453AbgIPAs7 (ORCPT ); Tue, 15 Sep 2020 20:48:59 -0400 Received: from X1 (unknown [67.22.170.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FC9420770; Wed, 16 Sep 2020 00:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600217336; bh=WyF3P7Aqu/5jOAe8bgWDIiaXqgmy/5Hi7Hqfi1YYGxM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bVYT1hmrZROX6bU3uwWE4x610xoug0ite08lGt2IcjKJ6EyBQJmob8oF/a7+334XQ 70TOEGz0Btq6bzmP3GD+86mAZXStilE+tuTXtJArwowTBMTdNdU0NWgFPUAFg3s93/ t07TYXV5YLomk2UW96M71H3gFsP6l2Ufvl5+iH6o= Date: Tue, 15 Sep 2020 17:48:55 -0700 From: Andrew Morton To: Cc: , Subject: Re: [PATCH] mm/page_alloc.c: variable type of 'progress' should be 'unsigned long' Message-Id: <20200915174855.822d866316948aadb8193e9b@linux-foundation.org> In-Reply-To: <20200915104620.20582-1-yanfei.xu@windriver.com> References: <20200915104620.20582-1-yanfei.xu@windriver.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Sep 2020 18:46:20 +0800 wrote: > From: Yanfei Xu > > try_to_free_pages returns the number of pages reclaimed, and the type of > returns is 'unsigned long'. So we should use a matched type for storing > it. > __perform_reclaim() returns an int, so this change is fairly pointless. However __perform_reclaim()'s single caller expects it to return unsigned long, so including that change in this patch would make more sense.