Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ran Wang <ran.wang_1@nxp.com>
To:     kuldip dwivedi <kuldip.dwivedi@puresoftware.com>,
        Leo Li <leoyang.li@nxp.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Biwen Li <biwen.li@nxp.com>, Varun Sethi <V.Sethi@nxp.com>,
        Arokia Samy <arokia.samy@nxp.com>,
        Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
        Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
        Paul Yang <Paul.Yang@arm.com>,
        kuldip dwivedi <kuldip.dwivedi@puresoftware.com>,
        tanveer <tanveer.alam@puresoftware.com>
Subject: RE: [PATCH v1] soc: fsl: rcpm: Add ACPI support
Thread-Topic: [PATCH v1] soc: fsl: rcpm: Add ACPI support
Thread-Index: AQHWi1Bdrf69Hjks3kmx49279KDQI6lqdRfQ
Date:   Wed, 16 Sep 2020 01:21:44 +0000
Message-ID: <AM6PR04MB5413CCFCC68AE2BF90C72C47F1210@AM6PR04MB5413.eurprd04.prod.outlook.com>
References: <20200915110647.846-1-kuldip.dwivedi@puresoftware.com>
In-Reply-To: <20200915110647.846-1-kuldip.dwivedi@puresoftware.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a2f0fac-aefa-4ab5-ce0b-08d859dedfbb
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2020 01:21:44.3494
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DdU82NemEaJIFHg30ffA3HcTnMk6TJhJpCGSYmfROL9DchVNUkReFByxj942ZuCnkMnm6xsXEMdxi5kDxitWRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4742
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Kuldip,

On Tuesday, September 15, 2020 7:07 PM, kuldip dwivedi wrote:
> Subject: [PATCH v1] soc: fsl: rcpm: Add ACPI support

Actually I also post a patch for this recently: https://lore.kernel.org/pat=
chwork/patch/1299959/  :)

Regards,
Ran

> Add ACPI support in fsl RCPM driver. This is required to support ACPI S3 =
state.
> S3 is the ACPI sleep state that is known as "sleep" or "suspend to RAM".
> It essentially turns off most power of the system but keeps memory powere=
d.

Actually the low power mode is to gate clocks rather than power down on Lay=
erscape platforms.

> Signed-off-by: tanveer <tanveer.alam@puresoftware.com>
> Signed-off-by: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
> ---
>=20
> Notes:
>     1. Add ACPI match table
>     2. NXP team members are added for confirming HID changes
>     3. There is only one node in ACPI so no need to check for
>        current device explicitly
>     4. These changes are tested on LX2160A and LS1046A platforms
>=20
>  drivers/soc/fsl/rcpm.c | 22 +++++++++++++++++++---
>  1 file changed, 19 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/soc/fsl/rcpm.c b/drivers/soc/fsl/rcpm.c index
> a093dbe6d2cb..e75a436fb159 100644
> --- a/drivers/soc/fsl/rcpm.c
> +++ b/drivers/soc/fsl/rcpm.c
> @@ -2,10 +2,12 @@
>  //
>  // rcpm.c - Freescale QorIQ RCPM driver  // -// Copyright 2019 NXP
> +// Copyright 2019-2020 NXP
> +// Copyright 2020 Puresoftware Ltd.
>  //
>  // Author: Ran Wang <ran.wang_1@nxp.com>
>=20
> +#include <linux/acpi.h>
>  #include <linux/init.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> @@ -57,8 +59,13 @@ static int rcpm_pm_prepare(struct device *dev)
>  				rcpm->wakeup_cells + 1);
>=20
>  		/*  Wakeup source should refer to current rcpm device */
> -		if (ret || (np->phandle !=3D value[0]))
> -			continue;
> +		if (is_acpi_node(dev->fwnode)) {
> +			if (ret)
> +				continue;
> +		} else {
> +			if (ret || (np->phandle !=3D value[0]))
> +				continue;
> +		}
>  		/* Property "#fsl,rcpm-wakeup-cells" of rcpm node defines the
>  		 * number of IPPDEXPCR register cells, and "fsl,rcpm-wakeup"
> @@ -139,10 +146,19 @@ static const struct of_device_id rcpm_of_match[] =
=3D
> {  };  MODULE_DEVICE_TABLE(of, rcpm_of_match);
>=20
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id rcpm_acpi_match[] =3D {
> +	{ "NXP0015", },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(acpi, rcpm_acpi_match); #endif
> +
>  static struct platform_driver rcpm_driver =3D {
>  	.driver =3D {
>  		.name =3D "rcpm",
>  		.of_match_table =3D rcpm_of_match,
> +		.acpi_match_table =3D ACPI_PTR(rcpm_acpi_match),
>  		.pm	=3D &rcpm_pm_ops,
>  	},
>  	.probe =3D rcpm_probe,
> --
> 2.17.1