Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200915132741.84869-1-zangchunxin@bytedance.com>
 <20200915144737.GA2581123@chrisdown.name> <20200915145533.GG3736@dhcp22.suse.cz>
 <20200915162604.GB2581123@chrisdown.name>
In-Reply-To: <20200915162604.GB2581123@chrisdown.name>
From:   Chunxin Zang <zangchunxin@bytedance.com>
Date:   Wed, 16 Sep 2020 10:36:48 +0800
Message-ID: <CAKRVAePsLTRzQC+5dYYYQ+x+fk8ogoME9uuobzyeJ2J-6kNHPg@mail.gmail.com>
Subject: Re: [External] Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node
To:     Chris Down <chris@chrisdown.name>
Cc:     Michal Hocko <mhocko@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Muchun Song <songmuchun@bytedance.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Sep 16, 2020 at 12:26 AM Chris Down <chris@chrisdown.name> wrote:
>
> Michal Hocko writes:
> >On Tue 15-09-20 15:47:37, Chris Down wrote:
> >> zangchunxin@bytedance.com writes:
> >> > +          if (signal_pending(current))
> >> > +                  return;
> >>
> >> This doesn't match your patch title, please update it. :-)
> >
> >I have to admit I have completely missed this and I think that this
> >should better be fatal_signal_pending because that would make sure that
> >the userspace will not see an incomplete operation. This is a general
> >practice for other bail outs as well.
>
> Oh sorry, to be clear, I meant the patch should match the title, not the other
> way around.

My apologies about that. In my first version of patch, it's
'fatal_signal_pending'.
But in this version, I used the wrong branch. I will update it now.

Best wishes
Chunxin