Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Reply-To: Gavin Shan <gshan@redhat.com>
Subject: Re: [PATCH -next] firmware: arm_sdei: simplify the return expression
 of sdei_device_freeze()
To:     Liu Shixin <liushixin2@huawei.com>,
        James Morse <james.morse@arm.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <20200915032625.1772413-1-liushixin2@huawei.com>
From:   Gavin Shan <gshan@redhat.com>
Message-ID: <9fdd9c4d-d957-e7d5-818d-cc9247be9dfd@redhat.com>
Date:   Wed, 16 Sep 2020 13:40:16 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.0
MIME-Version: 1.0
In-Reply-To: <20200915032625.1772413-1-liushixin2@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/15/20 1:26 PM, Liu Shixin wrote:
> Simplify the return expression.
> 
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---

Reviewed-by: Gavin Shan <gshan@redhat.com>

>   drivers/firmware/arm_sdei.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> index b4b9ce97f415..5b4c8c51cb20 100644
> --- a/drivers/firmware/arm_sdei.c
> +++ b/drivers/firmware/arm_sdei.c
> @@ -798,16 +798,10 @@ static int sdei_device_resume(struct device *dev)
>    */
>   static int sdei_device_freeze(struct device *dev)
>   {
> -	int err;
> -
>   	/* unregister private events */
>   	cpuhp_remove_state(CPUHP_AP_ARM_SDEI_STARTING);
>   
> -	err = sdei_unregister_shared();
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return sdei_unregister_shared();
>   }
>   
>   static int sdei_device_thaw(struct device *dev)
>